761494 - Cannot open all Bookmarks in tabs by Middle-clicking a folder in Sidebar (Ctrl+click open in all tabs and Shift+click open all in window also do not work)

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Alice0775 White]

http://hg.mozilla.org/mozilla-central/rev/dd6ec482a85d
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:15.0) Gecko/15.0 Firefox/15.0a1 ID:20120604030527

Steps to Reproduce:

1. Start Browser with new profile
2. Open Sidebar (Ctrl+B)
3. Expand tree and middle click a folder

Actual Results:  
  Nothing happens
  And an error appears in Error Console as follows.

Error: TypeError: tbo.view.nodeForTreeIndex is not a function
Source file: chrome://browser/content/bookmarks/sidebarUtils.js
Line: 41


Expected Results:  
  All Bookmarks in the folder should be opened in tabs

Regression window(m-c)
Good:
http://hg.mozilla.org/mozilla-central/rev/d0ebcaa7efb5
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:15.0) Gecko/15.0 Firefox/15.0a1 ID:20120603030523
Bad:
http://hg.mozilla.org/mozilla-central/rev/07d362aa2c1b
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:15.0) Gecko/15.0 Firefox/15.0a1 ID:20120603120904
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=d0ebcaa7efb5&tochange=07d362aa2c1b



Regression window(m-c)
Good:
http://hg.mozilla.org/integration/mozilla-inbound/rev/ddd5acd40b93
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:15.0) Gecko/15.0 Firefox/15.0a1 ID:20120603032105
Bad:
http://hg.mozilla.org/integration/mozilla-inbound/rev/b1b44a491f6a
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:15.0) Gecko/15.0 Firefox/15.0a1 ID:20120603055102
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=ddd5acd40b93&tochange=b1b44a491f6a

Suspected; Bug 730340

Comment 1

[Grant]

Does this for me on the bookmark toolbar, even right clicking on the folder the "open all in tabs" is greyed out too.

Comment 2

[Alice0775 White]

(In reply to Grant from comment #1)
> Does this for me on the bookmark toolbar, even right clicking on the folder
> the "open all in tabs" is greyed out too.
WFM on Bookmarks Toolbar. Are you try in New profile?

Comment 3

[Alice0775 White]

In Sidebar, Ctrl+clcik open in all tabs and Shift+click open all in window also do not work.

Comment 4

[Danial Horton]

You beat me to the bug Alice, i was just about to enter this.

Comment 5

[Asaf Romano (gone)]

Attachment: patch

Comment 6

[Asaf Romano (gone)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/4d766f24e6a4

Comment 7

[Asaf Romano (gone)]

Comment on attachment 637593 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 730340 
User impact if declined: Some addons which mess with places trees could break, plus this bug.
Testing completed (on m-c, etc.): No tests for this functionality yet (will do in a follow up) 
Risk to taking this patch (and alternatives if risky): there's a one-liner alternative (QI to nsINavHistoryResultTreeViewer in tree.xml's view setter), but this shouldn't be risky.
String or UUID changes made by this patch: none.

Comment 8

[Asaf Romano (gone)]

http://hg.mozilla.org/releases/mozilla-aurora/rev/e20f71378b68

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/4d766f24e6a4

Comment 10

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 637593 [details] [diff] [review]
patch

Review of attachment 637593 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/places/content/treeView.js
@@ +50,5 @@
> +
> +  // Bug 761494:
> +  // ----------
> +  // Some addons use methods from nsINavHistoryResultObserver and
> +  // nsINavHistoryResultTreeViewer, without QIing to these intefaces first.

interfaces

Comment 11

[Ioana (away)]

Verified as fixed on:
Mozilla/5.0 (Windows NT 6.1; rv:15.0) Gecko/20100101 Firefox/15.0

Comment 12

[zephyrer]

Unfortunately, this bug is reappeared in latest nightly version: Firefox 60.0a1 (2018-01-24)
User agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:60.0) Gecko/20100101 Firefox/60.0
Build ID: 20180124100321

Comment 13

[Mark Banner (:standard8)]

(In reply to zephyrer from comment #12)
> Unfortunately, this bug is reappeared in latest nightly version: Firefox
> 60.0a1 (2018-01-24)
> User agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:60.0)
> Gecko/20100101 Firefox/60.0
> Build ID: 20180124100321

Please don't comment on long-fixed bugs, the cause is likely to be very different and your comments are likely to be lost. Please file a new bug, and if possible provide a regression range using mozregression.