Closed
Bug 761531
Opened 12 years ago
Closed 12 years ago
FileIOObject should add mError in CC
Categories
(Core Graveyard :: File Handling, defect)
Core Graveyard
File Handling
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla16
People
(Reporter: mounir, Assigned: mounir)
Details
Attachments
(1 file)
|
1.44 KB,
patch
|
smaug
:
review+
mounir
:
checkin+
|
Details | Diff | Splinter Review |
It is missing from:
NS_IMPL_CYCLE_COLLECTION_TRAVERSE_BEGIN_INHERITED and NS_IMPL_CYCLE_COLLECTION_UNLINK_BEGIN_INHERITED and I believe it should be added here as:
NS_IMPL_CYCLE_COLLECTION_TRAVERSE_NSCOMPTR(mError) and NS_IMPL_CYCLE_COLLECTION_UNLINK_NSCOMPTR(mError)
|
Assignee | |
Comment 1•12 years ago
|
||
|
||
Comment 2•12 years ago
|
||
Comment on attachment 630119 [details] [diff] [review]
Patch
In practice this shouldn't matter atm, since DOMError shouldn't keep anything
alive. But this is future-proof. Once DOMError starts to use new bindings,
it may keep stuff alive.
Attachment #630119 -
Flags: review?(bugs) → review+
|
|
Assignee | |
Updated•12 years ago
|
Flags: in-testsuite-
Target Milestone: --- → mozilla16
|
|
Assignee | |
Updated•12 years ago
|
Attachment #630119 -
Flags: checkin+
|
||
Comment 3•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Updated•8 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•