FileIOObject should add mError in CC

RESOLVED FIXED in mozilla16

Status

Core Graveyard
File Handling
RESOLVED FIXED
5 years ago
11 months ago

People

(Reporter: mounir, Assigned: mounir)

Tracking

Trunk
mozilla16
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
It is missing from:
NS_IMPL_CYCLE_COLLECTION_TRAVERSE_BEGIN_INHERITED and NS_IMPL_CYCLE_COLLECTION_UNLINK_BEGIN_INHERITED and I believe it should be added here as:
NS_IMPL_CYCLE_COLLECTION_TRAVERSE_NSCOMPTR(mError) and NS_IMPL_CYCLE_COLLECTION_UNLINK_NSCOMPTR(mError)
(Assignee)

Comment 1

5 years ago
Created attachment 630119 [details] [diff] [review]
Patch
Assignee: nobody → mounir
Status: NEW → ASSIGNED
Attachment #630119 - Flags: review?(bugs)

Comment 2

5 years ago
Comment on attachment 630119 [details] [diff] [review]
Patch

In practice this shouldn't matter atm, since DOMError shouldn't keep anything
alive. But this is future-proof. Once DOMError starts to use new bindings,
it may keep stuff alive.
Attachment #630119 - Flags: review?(bugs) → review+
(Assignee)

Updated

5 years ago
Flags: in-testsuite-
Target Milestone: --- → mozilla16
(Assignee)

Updated

5 years ago
Attachment #630119 - Flags: checkin+
https://hg.mozilla.org/mozilla-central/rev/4f99c2d9741e
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.