If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Do not hardcode /data/data directories

RESOLVED FIXED in Firefox 16

Status

()

Firefox for Android
General
--
minor
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: gcp, Unassigned)

Tracking

Trunk
Firefox 16
ARM
Android
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
From Bug 738168: We hardcode "/data/data" in several places. We probably shouldn't do that but find this directory though Android functions instead.

embedding/android/CrashReporter.java.in:      new File("/data/data/@ANDROID_PACKAGE_NAME@/files/mozilla/Crash Reports/pending");
embedding/android/CrashReporter.java.in:          "/data/data/@ANDROID_PACKAGE_NAME@/files/mozilla/Crash Reports/submitted");
embedding/android/GeckoAppShell.java:            File oldHome = new File("/data/data/" + 
embedding/android/GeckoAppShell.java:            File oldHome = new File("/data/data/" + 
mobile/android/base/CrashReporter.java.in:    private static final String CRASH_REPORT_DIR = "/data/data/@ANDROID_PACKAGE_NAME@/files/mozilla/Crash Reports/";
(Reporter)

Comment 1

5 years ago
Created attachment 630225 [details] [diff] [review]
Patch 1. Do not hardcode directories. Update XUL.

This also updates the XUL crash reporter to be identical to the Native one, which fixes things like bug 702624 (XUL still suffers from it as far as I can tell!).
Attachment #630225 - Flags: review?(blassey.bugs)
Attachment #630225 - Flags: review?(blassey.bugs) → review+
(Reporter)

Comment 2

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/08229e1f4ad0
https://hg.mozilla.org/mozilla-central/rev/08229e1f4ad0
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 16
You need to log in before you can comment on or make changes to this bug.