Closed Bug 761569 Opened 9 years ago Closed 9 years ago

Failure in testCloseWindow | can't access dead object

Categories

(Mozilla QA Graveyard :: Mozmill Tests, defect)

All
macOS
defect
Not set
normal

Tracking

(firefox13 fixed, firefox14 fixed, firefox15 fixed, firefox16 fixed, firefox-esr10 fixed)

RESOLVED FIXED
Tracking Status
firefox13 --- fixed
firefox14 --- fixed
firefox15 --- fixed
firefox16 --- fixed
firefox-esr10 --- fixed

People

(Reporter: remus.pop, Assigned: whimboo)

References

()

Details

(Whiteboard: [qa-])

Attachments

(1 file)

No description provided.
This happens in Nightly on Mac OSX.
Copying over the comment with what was tried towards finding the problematic lines in the test:

After this line I inserted a sleep(2000).
http://hg.mozilla.org/qa/mozmill-tests/file/73b913d2b1f4/tests/functional/testPrivateBrowsing/testCloseWindow.js#l87

The failure complains about a new elementslib when executing this._view = _document.defaultView;
So I think the DOM is not ready when executing line 88: var tab = controller.tabs.getTab(i);
Summary: Failure in testCloseWindow → Failure in testCloseWindow | can't access dead object
We would have to recreate the controller and tabBrowser instance because they would operate on a window which already has been closed.
Attached patch Patch v1Splinter Review
The problem we are facing here is that controller.tabs.getTab() is broken and returns a document which defaultView is not valid anymore. This is most likely a Mozmill bug which I will file tomorrow.

Thankfully we can make use of controller.tabs.activeTab here so we can workaround the problem.

This patch fixes this issue and also makes the code a bit cleaner.
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Attachment #630768 - Flags: review?(anthony.s.hughes)
Attachment #630768 - Flags: feedback?(remus.pop)
Comment on attachment 630768 [details] [diff] [review]
Patch v1

Review of attachment 630768 [details] [diff] [review]:
-----------------------------------------------------------------

Patch looks fine to me.
Attachment #630768 - Flags: review?(anthony.s.hughes) → review+
Comment on attachment 630768 [details] [diff] [review]
Patch v1

Looks good and works fine. Great for finding such a simple fix.
Attachment #630768 - Flags: feedback?(remus.pop) → feedback+
Pushed to default for now:
http://hg.mozilla.org/qa/mozmill-tests/rev/4776b926c148

If we pass now I can backport to aurora later.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [qa-]
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in before you can comment on or make changes to this bug.