Failure in testCloseWindow | can't access dead object

RESOLVED FIXED

Status

Mozilla QA
Mozmill Tests
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: RemusPop, Assigned: whimboo)

Tracking

unspecified
All
Mac OS X

Firefox Tracking Flags

(firefox13 fixed, firefox14 fixed, firefox15 fixed, firefox16 fixed, firefox-esr10 fixed)

Details

(Whiteboard: [qa-], URL)

Attachments

(1 attachment)

Comment hidden (empty)
(Reporter)

Comment 1

5 years ago
This happens in Nightly on Mac OSX.
Copying over the comment with what was tried towards finding the problematic lines in the test:

After this line I inserted a sleep(2000).
http://hg.mozilla.org/qa/mozmill-tests/file/73b913d2b1f4/tests/functional/testPrivateBrowsing/testCloseWindow.js#l87

The failure complains about a new elementslib when executing this._view = _document.defaultView;
So I think the DOM is not ready when executing line 88: var tab = controller.tabs.getTab(i);
Summary: Failure in testCloseWindow → Failure in testCloseWindow | can't access dead object
(Assignee)

Comment 2

5 years ago
We would have to recreate the controller and tabBrowser instance because they would operate on a window which already has been closed.
status-firefox15: --- → affected
status-firefox16: --- → affected
(Assignee)

Comment 3

5 years ago
Created attachment 630768 [details] [diff] [review]
Patch v1

The problem we are facing here is that controller.tabs.getTab() is broken and returns a document which defaultView is not valid anymore. This is most likely a Mozmill bug which I will file tomorrow.

Thankfully we can make use of controller.tabs.activeTab here so we can workaround the problem.

This patch fixes this issue and also makes the code a bit cleaner.
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Attachment #630768 - Flags: review?(anthony.s.hughes)
Attachment #630768 - Flags: feedback?(remus.pop)
Comment on attachment 630768 [details] [diff] [review]
Patch v1

Review of attachment 630768 [details] [diff] [review]:
-----------------------------------------------------------------

Patch looks fine to me.
Attachment #630768 - Flags: review?(anthony.s.hughes) → review+
(Reporter)

Comment 5

5 years ago
Comment on attachment 630768 [details] [diff] [review]
Patch v1

Looks good and works fine. Great for finding such a simple fix.
Attachment #630768 - Flags: feedback?(remus.pop) → feedback+
(Assignee)

Comment 6

5 years ago
Pushed to default for now:
http://hg.mozilla.org/qa/mozmill-tests/rev/4776b926c148

If we pass now I can backport to aurora later.
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
status-firefox16: affected → fixed
Resolution: --- → FIXED
(Assignee)

Comment 7

5 years ago
Tests for Nightly builds don't show this failure anymore. Pushed patch to all older branches due to improvements of stability:

http://hg.mozilla.org/qa/mozmill-tests/rev/e6ca41d437d5 (aurora)
http://hg.mozilla.org/qa/mozmill-tests/rev/f323d63f3db5 (beta)
http://hg.mozilla.org/qa/mozmill-tests/rev/057e6dea86ba (release)
http://hg.mozilla.org/qa/mozmill-tests/rev/33d2c0559cf2 (esr10)
status-firefox-esr10: --- → fixed
status-firefox13: --- → fixed
status-firefox14: --- → fixed
status-firefox15: affected → fixed

Updated

5 years ago
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.