Closed Bug 761659 Opened 12 years ago Closed 8 years ago

[shipping] show appversion in team snippet if possible

Categories

(Webtools Graveyard :: Elmo, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Pike, Assigned: Pike)

References

Details

Attachments

(2 files)

If there's a appversion for the current tree, show the appversion in the column where right now there's only the tree. The tree should be still shown in small and grey text, though.
Priority: -- → P3
low-hanging fruit, taking as a ride-along.
Assignee: nobody → l10n
I did a couple of things here: - if the appversion exists, show that. - show the tree, in smaller font Ridealong fixes: Only show the (de) locale code suffix if it's not the primary locale. That regressed at some point, and I fixed that. Sort by version instead of tree code. That way, the odd order of aurora/beta/central is moved over to central/aurora/beta. Most often, at least, there's probably weirdness, as I'm sorting by version string, not number. Mostly because I don't want to assume it's actually a number. Feedback welcome.
It looks good but I'm not sold on using two different font sizes on the same line.
Updated, better? I took away the font-weight from the tee name instead of making it a smaller font. I think that looks OK. I picked <small> because locale already used that. In this screenshot, I used font-size: small, and unset that a few times, see annotation in the screenshot. :-?
(In reply to Axel Hecht [:Pike] from comment #4) > Updated, better? Definitely better, the unset one for the team looks better.
Commit pushed to develop at https://github.com/mozilla/elmo https://github.com/mozilla/elmo/commit/73784abe9a59fa5e1ec1d2b874195b254522c12c bug 761659, show app version if available, f=flod Also fix a regression where we always showed the locale code. And stop using a small font.
Landed and deployed on stage. I'll work on prod next week.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Deployed on prod now, too.
Product: Webtools → Webtools Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: