761742 - No script is loaded in the script debugger for me

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P2)

Description

[(no longer active)]

Almost every time I look at the script debugger, it's empty, and the drop-down box for selecting the script is turned off as well.  This happens on various web pages, which _do_ have scripts on them.  Nothing on the error console, etc.  I'm not sure what other information I need to provide here.

Comment 1

[Panos Astithas (he/him) [:past] (please ni?)]

Could it be related to the issues you described in bug 761302?

Comment 2

[(no longer active)]

(In reply to Panos Astithas [:past] from comment #1)
> Could it be related to the issues you described in bug 761302?

I'm not sure, that was the first and only time that the script debugger worked for me.  After I restarted, it stopped working again (this bug).

Comment 3

[Panos Astithas (he/him) [:past] (please ni?)]

(In reply to Ehsan Akhgari [:ehsan] from comment #2)
> (In reply to Panos Astithas [:past] from comment #1)
> > Could it be related to the issues you described in bug 761302?
> 
> I'm not sure, that was the first and only time that the script debugger
> worked for me.  After I restarted, it stopped working again (this bug).

Does it happen in a clean profile or safe mode, too? Do you have any special network configuration settings that could interfere with the debugger's fetching of the script files? Can you enable devtools.debugger.log and post or send me the console output?

Comment 4

[(no longer active)]

I have not tried on another profile.  I'm assuming that it works since nobody else is complaining about this.  ;-)

I don't have any special settings which should affect this.  Turned on devtools.debugger.log and tried again, nothing logged to the error console.

Comment 5

[Panos Astithas (he/him) [:past] (please ni?)]

(In reply to Ehsan Akhgari [:ehsan] from comment #4)
> I have not tried on another profile.  I'm assuming that it works since
> nobody else is complaining about this.  ;-)
> 
> I don't have any special settings which should affect this.  Turned on
> devtools.debugger.log and tried again, nothing logged to the error console.

Sorry, I wasn't clear, devtools.debugger.log provides dump() output, that should be visible in stdout if you start Firefox from the command line.

Comment 6

[(no longer active)]

This is what I got: https://gist.github.com/2884324

Comment 7

[Panos Astithas (he/him) [:past] (please ni?)]

From the log it looks like you opened the debugger in a page that contained the attachment from a bugzilla bug, i.e. a page without any scripts. In that case having an empty script list is normal. If you visit the actual bugzilla page and still see no scripts, then I'd like to see the new log.

Comment 8

[(no longer active)]

(In reply to Panos Astithas [:past] from comment #7)
> From the log it looks like you opened the debugger in a page that contained
> the attachment from a bugzilla bug, i.e. a page without any scripts. In that
> case having an empty script list is normal. If you visit the actual bugzilla
> page and still see no scripts, then I'd like to see the new log.

Nope, I opened it up in Gmail.

Comment 9

[Panos Astithas (he/him) [:past] (please ni?)]

(In reply to Ehsan Akhgari [:ehsan] from comment #8)
> (In reply to Panos Astithas [:past] from comment #7)
> > From the log it looks like you opened the debugger in a page that contained
> > the attachment from a bugzilla bug, i.e. a page without any scripts. In that
> > case having an empty script list is normal. If you visit the actual bugzilla
> > page and still see no scripts, then I'd like to see the new log.
> 
> Nope, I opened it up in Gmail.

Then I don't understand. The log shows that when the debugger was opened the current tab was conn0.tab58 (which is a bugzilla attachment), in which it attempted to connect and succeeded. There is no indication of connecting to one of the gmail tabs. Do you use the menu item Tools -> Web Developer -> Debugger to open the debugger or something else?

Comment 10

[(no longer active)]

I used the keyboard shortcut but that shouldn't make any difference...  This sort of suggests to me that we have a bug which causes us to select the wrong tab when the dbeugger opens up.

Comment 11

[Panos Astithas (he/him) [:past] (please ni?)]

(In reply to Ehsan Akhgari [:ehsan] from comment #10)
> I used the keyboard shortcut but that shouldn't make any difference...  This
> sort of suggests to me that we have a bug which causes us to select the
> wrong tab when the dbeugger opens up.

I always use the keyboard shortcut, too, so this makes no sense to me. Perhaps you could record a screencast for me, to see if I can find any more leads?

Comment 12

[(no longer active)]

I just press Cmd+Option+S!  Is a screencase of doing that really necessary?

Comment 13

[(no longer active)]

This is the about:support page from this profile:

https://gist.github.com/2890281

Comment 14

[Panos Astithas (he/him) [:past] (please ni?)]

As discussed in IRC, a possibly interesting information is that Ehsan has three windows open when starting the debugger. I'll try to reproduce this again tomorrow.

Comment 15

[Panos Astithas (he/him) [:past] (please ni?)]

I think I see the problem now, with multiple windows open the selected tab is not always the correct one. If we end up fixing this in bug 710258, I'll dupe it to that.

Comment 16

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: WIP

The fix is simple, but the test needs more work.

Comment 17

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: Patch v2

Test fixed. Try run:
https://tbpl.mozilla.org/?tree=Try&rev=ad25d7953cc6

Comment 18

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: Patch v3

Slight test tweaking to avoid an orange.

Comment 19

[Panos Astithas (he/him) [:past] (please ni?)]

New try run:
https://tbpl.mozilla.org/?tree=Try&rev=9c840b41e32e

Comment 20

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: Patch v4

Some oranges still. Hopefully this change will fix them:
https://tbpl.mozilla.org/?tree=Try&rev=310221f64e6d

Comment 21

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/integration/fx-team/rev/3e8a7c61048a

Comment 22

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/mozilla-central/rev/3e8a7c61048a

Comment 23

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 634080 [details] [diff] [review]
Patch v4

[Approval Request Comment]
Bug caused by (feature/regressing bug #): New feature
User impact if declined: developers with multiple browser windows open will be unable to use the debugger in some cases
Testing completed (on m-c, etc.): On m-c and fx-team
Risk to taking this patch (and alternatives if risky): this is a trivial 2-line patch, so risk is minimal
String or UUID changes made by this patch: none

Comment 24

[Alex Keybl [:akeybl]]

Comment on attachment 634080 [details] [diff] [review]
Patch v4

[Triage Comment]
Low risk fix for a new dev tools feature.

Comment 25

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/b11b719c66a0

Comment 26

[(no longer active)]

This patch did not fix the problem.  I can still reproduce.

Comment 27

[Panos Astithas (he/him) [:past] (please ni?)]

(In reply to Ehsan Akhgari [:ehsan] from comment #26)
> This patch did not fix the problem.  I can still reproduce.

Can you provide me with some logs (like in comment 6) and a screenshot of your desktop, or something that could help me identify the tabs in your open browser windows and their z-order?

Comment 28

[(no longer active)]

After some debugging over IRC, we realized that the Gecko Profiler add-on breaks the debugger.  Turning that off fixes this.

Comment 29

[Benoit Girard (:BenWa)]

Sorry about that. I released an update:
https://github.com/bgirard/Gecko-Profiler-Addon/commit/7e85b232b2e814df815238989a5c93e916c2692a