The default bug view has changed. See this FAQ.

inner-window-destroyed observer gets added twice for webapps

RESOLVED FIXED in mozilla16

Status

()

Core
DOM: Device Interfaces
--
major
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: lightsofapollo, Assigned: gwagner)

Tracking

Trunk
mozilla16
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Observed in a recent build of B2G Desktop and Firefox nightly while testing gaia master.


Exception ->

* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "'[JavaScript Error: "this._messages is null" {file: "resource://gre/modules/DOMRequestHelper.jsm" line: 88}]' when calling method: [nsIObserver::observe]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0"  data: yes]
(Assignee)

Updated

5 years ago
Summary: window.navigator.mozSettings throws an error → JavaScript Error: "this._messages is null" file: "resource://gre/modules/DOMRequestHelper.jsm" line: 88
(Assignee)

Updated

5 years ago
Assignee: nobody → anygregor
(Assignee)

Comment 1

5 years ago
Created attachment 630616 [details] [diff] [review]
patch
(Assignee)

Comment 2

5 years ago
We register inner-window-destroyed" twice. Once in initHelper and right after in init again.
(Assignee)

Updated

5 years ago
Attachment #630616 - Flags: review?(fabrice)
(Assignee)

Comment 3

5 years ago
https://tbpl.mozilla.org/?tree=Try&rev=cf466c03f09a
(Assignee)

Comment 4

5 years ago
The try run showed some intermittent failures that didn't look intermittent any more. I pushed again
https://tbpl.mozilla.org/?tree=Try&rev=0c8fc3c406b4
(Assignee)

Comment 5

5 years ago
Created attachment 631012 [details] [diff] [review]
patch

The _id removal caused timeouts in the webapps tests.
Attachment #630616 - Attachment is obsolete: true
Attachment #630616 - Flags: review?(fabrice)
Attachment #631012 - Flags: review?(fabrice)
(Assignee)

Updated

5 years ago
Summary: JavaScript Error: "this._messages is null" file: "resource://gre/modules/DOMRequestHelper.jsm" line: 88 → inner-window-destroyed observer gets added twice for webapps
Attachment #631012 - Flags: review?(fabrice) → review+
(Assignee)

Comment 6

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/9ed07c7da57b
(Assignee)

Comment 7

5 years ago
ahhh so we can't remove the outerWindowID: http://mxr.mozilla.org/mozilla-central/source/browser/modules/webappsUI.jsm#92
https://hg.mozilla.org/mozilla-central/rev/9ed07c7da57b

(Merged by Ed Morley)
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
You need to log in before you can comment on or make changes to this bug.