761837 - inner-window-destroyed observer gets added twice for webapps

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[James Lal [:lightsofapollo]]

Observed in a recent build of B2G Desktop and Firefox nightly while testing gaia master.


Exception ->

* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "'[JavaScript Error: "this._messages is null" {file: "resource://gre/modules/DOMRequestHelper.jsm" line: 88}]' when calling method: [nsIObserver::observe]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0"  data: yes]

Comment 1

[Gregor Wagner [:gwagner]]

Attachment: patch

Comment 2

[Gregor Wagner [:gwagner]]

We register inner-window-destroyed" twice. Once in initHelper and right after in init again.

Comment 3

[Gregor Wagner [:gwagner]]

https://tbpl.mozilla.org/?tree=Try&rev=cf466c03f09a

Comment 4

[Gregor Wagner [:gwagner]]

The try run showed some intermittent failures that didn't look intermittent any more. I pushed again
https://tbpl.mozilla.org/?tree=Try&rev=0c8fc3c406b4

Comment 5

[Gregor Wagner [:gwagner]]

Attachment: patch

The _id removal caused timeouts in the webapps tests.

Comment 6

[Gregor Wagner [:gwagner]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9ed07c7da57b

Comment 7

[Gregor Wagner [:gwagner]]

ahhh so we can't remove the outerWindowID: http://mxr.mozilla.org/mozilla-central/source/browser/modules/webappsUI.jsm#92

Comment 8

[Graeme McCutcheon [:graememcc]]

https://hg.mozilla.org/mozilla-central/rev/9ed07c7da57b

(Merged by Ed Morley)