Closed Bug 761837 Opened 12 years ago Closed 12 years ago

inner-window-destroyed observer gets added twice for webapps

Categories

(Core :: DOM: Device Interfaces, defect)

x86
macOS
defect
Not set
major

Tracking

()

RESOLVED FIXED
mozilla16

People

(Reporter: jlal, Assigned: gwagner)

Details

Attachments

(1 file, 1 obsolete file)

Observed in a recent build of B2G Desktop and Firefox nightly while testing gaia master.


Exception ->

* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "'[JavaScript Error: "this._messages is null" {file: "resource://gre/modules/DOMRequestHelper.jsm" line: 88}]' when calling method: [nsIObserver::observe]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0"  data: yes]
Summary: window.navigator.mozSettings throws an error → JavaScript Error: "this._messages is null" file: "resource://gre/modules/DOMRequestHelper.jsm" line: 88
Assignee: nobody → anygregor
Attached patch patch (obsolete) — Splinter Review
We register inner-window-destroyed" twice. Once in initHelper and right after in init again.
Attachment #630616 - Flags: review?(fabrice)
The try run showed some intermittent failures that didn't look intermittent any more. I pushed again
https://tbpl.mozilla.org/?tree=Try&rev=0c8fc3c406b4
Attached patch patchSplinter Review
The _id removal caused timeouts in the webapps tests.
Attachment #630616 - Attachment is obsolete: true
Attachment #630616 - Flags: review?(fabrice)
Attachment #631012 - Flags: review?(fabrice)
Summary: JavaScript Error: "this._messages is null" file: "resource://gre/modules/DOMRequestHelper.jsm" line: 88 → inner-window-destroyed observer gets added twice for webapps
Attachment #631012 - Flags: review?(fabrice) → review+
https://hg.mozilla.org/mozilla-central/rev/9ed07c7da57b

(Merged by Ed Morley)
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
You need to log in before you can comment on or make changes to this bug.