content/base/test/test_bug518104.html has race between <iframe> and parent document script

RESOLVED FIXED in mozilla16

Status

()

Core
DOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: bhackett, Assigned: bhackett)

Tracking

Trunk
mozilla16
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
This test has an <iframe> with a deferred script that calls a function in the parent document.  According to bz the semantics here are that the iframe script can start executing as soon as the <iframe> is done being parsed, which may be before the parent script has finished parsing and the function installed on the global.  This is breaking in supersnappy, which is evaluating the scripts in this ordering.
(Assignee)

Comment 1

5 years ago
Created attachment 630393 [details] [diff] [review]
patch

This causes the parent.done() call to work and the test to pass with supersnappy.
Assignee: nobody → bhackett1024
Attachment #630393 - Flags: review?(bzbarsky)
(Assignee)

Comment 2

5 years ago
Created attachment 630397 [details] [diff] [review]
patch

Now with the correct patch.
Attachment #630393 - Attachment is obsolete: true
Attachment #630393 - Flags: review?(bzbarsky)
Attachment #630397 - Flags: review?(bzbarsky)
Comment on attachment 630397 [details] [diff] [review]
patch

r=me
Attachment #630397 - Flags: review?(bzbarsky) → review+
Blocks: 718121
Keywords: checkin-needed
OS: Mac OS X → All
Hardware: x86 → All
Version: Other Branch → Trunk
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/e758973c6ab1
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/e758973c6ab1

(Merged by Ed Morley)
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
You need to log in before you can comment on or make changes to this bug.