Closed Bug 761910 Opened 12 years ago Closed 12 years ago

add text attributes testing for HTML5 mark color


(Core :: Disability Access APIs, defect)

Not set





(Reporter: surkov, Assigned: drexler)


(Blocks 1 open bug)


(Whiteboard: [good first bug][][lang=js])


(1 file, 1 obsolete file)

w3c example: 
<p>Look around and you will find, no-one's really
 <mark>colour</mark> blind.</p>

add it to
similar to other examples in this file
Whiteboard: [good first bug][][lang=c++] → [good first bug][][lang=js]
Attached patch patch (obsolete) — Splinter Review
Added tests; passed locally.
Assignee: nobody → andrew.quartey
Attachment #633655 - Flags: review?(eitan)
Comment on attachment 633655 [details] [diff] [review]

Review of attachment 633655 [details] [diff] [review]:

Overall looks good. Please address the two issues below (either with a new patch or an explanation that I am wrong).

::: accessible/tests/mochitest/attributes/test_text.html
@@ +534,5 @@
> +      attrs = {};
> +      testTextAttrs(ID, 0, attrs, defAttrs, 0, 10);
> +      
> +      // Walk to the span with the different background color
> +      tempElem = getNode(ID).firstChild.nextSibling;

Can't you just give the <mark> tag an ID and get it that way? Seems more readable and less vulnerable to future breakage.

@@ +585,5 @@
> +  <a target="_blank"
> +     href=""
> +     title="Add text attributes testing for HTML5 mark color">
> +    Mozilla Bug 761910
> +  </a>

No need to add a reference to this bug since it is not the implementation bug, just the test bug.
Attachment #633655 - Flags: review?(eitan)
(In reply to Eitan Isaacson [:eeejay] from comment #2)

> Can't you just give the <mark> tag an ID and get it that way? Seems more
> readable and less vulnerable to future breakage.

The reason for it is that according to the spec:, the mark element is used within a quotation or block of text. Should i give it an ID, i will then have it as a tag within the body of the test. Another alternative will be to append it to a different test block, say "area10".
Attached patch updated_patchSplinter Review
From the DOM Inspector, i found the mark element to be a text leaf, likewise the span element. Since the test function testTextAttrs will eventually make calls to determine whether the element is accessible or not, failing in the latter case; directly accessing the element by its id doesn't seem to be the way to go. I think that's why other tests in the file involving the span element similarly avoided doing so.
Attachment #633655 - Attachment is obsolete: true
Attachment #634976 - Flags: review?(eitan)
review ping.
Comment on attachment 634976 [details] [diff] [review]

Sorry for the delay.
Attachment #634976 - Flags: review?(eitan) → review+
No problem.
Keywords: checkin-needed
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
You need to log in before you can comment on or make changes to this bug.