761979 - nsfilestreams.cpp(817) : warning C4700: uninitialized local variable 'rv' used

Status: RESOLVED FIXED

Description

[Makoto Kato [:m_kato]]

817 nsresult rv;
818 if (NS_FAILED(rv)) return rv;

Comment 1

[Makoto Kato [:m_kato]]

Created attachment 630500 [details] [diff] [review]
fix

Comment 2

[Jan Varga [:janv]]

Comment on attachment 630500 [details] [diff] [review]
fix

this was introduced by bug 749930
anyway, r=me

Comment 3

[Jason Duell [:jduell] (needinfo me)]

Comment on attachment 630500 [details] [diff] [review]
fix

Review of attachment 630500 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine to me too (in general, make sure to get a review from a necko peer for patches that touch necko code--though this one really is pretty easy to review :)

Let me know if you can land this, or I can do it for you.

cheers

Comment 4

[Makoto Kato [:m_kato]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3ab26a51118b

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/3ab26a51118b