Last Comment Bug 761979 - nsfilestreams.cpp(817) : warning C4700: uninitialized local variable 'rv' used
: nsfilestreams.cpp(817) : warning C4700: uninitialized local variable 'rv' used
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Networking: File (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla16
Assigned To: Makoto Kato [:m_kato]
:
:
Mentors:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2012-06-06 04:17 PDT by Makoto Kato [:m_kato]
Modified: 2012-06-07 05:46 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Attachments
fix (748 bytes, patch)
2012-06-06 04:17 PDT, Makoto Kato [:m_kato] 		jvarga: review+
jduell.mcbugs: review+
Details | Diff | Splinter Review
View All Add an attachment (proposed patch, testcase, etc.)

Description Makoto Kato [:m_kato] 2012-06-06 04:17:02 PDT 
817 nsresult rv;
818 if (NS_FAILED(rv)) return rv;
Comment 1 Makoto Kato [:m_kato] 2012-06-06 04:17:41 PDT 
Created attachment 630500 [details] [diff] [review]
fix
Comment 2 Jan Varga [:janv] 2012-06-06 04:33:54 PDT 
Comment on attachment 630500 [details] [diff] [review]
fix

this was introduced by bug 749930
anyway, r=me
Comment 3 Jason Duell [:jduell] (needinfo me) 2012-06-06 11:24:29 PDT 
Comment on attachment 630500 [details] [diff] [review]
fix

Review of attachment 630500 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine to me too (in general, make sure to get a review from a necko peer for patches that touch necko code--though this one really is pretty easy to review :)

Let me know if you can land this, or I can do it for you.

cheers
Comment 5 Ed Morley [:emorley] 2012-06-07 05:46:51 PDT 
https://hg.mozilla.org/mozilla-central/rev/3ab26a51118b
Note You need to log in before you can comment on or make changes to this bug.