Last Comment Bug 761997 - Cleanup nsHTMLEditRules::GetListItemState / nsHTMLEditRules::GetDefinitionListItemTypes
: Cleanup nsHTMLEditRules::GetListItemState / nsHTMLEditRules::GetDefinitionLis...
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Editor (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla16
Assigned To: :Ms2ger (⌚ UTC+1/+2)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-06-06 05:22 PDT by :Ms2ger (⌚ UTC+1/+2)
Modified: 2012-06-17 07:16 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v1 (5.40 KB, patch)
2012-06-06 05:22 PDT, :Ms2ger (⌚ UTC+1/+2)
ehsan: review+
Details | Diff | Splinter Review

Description :Ms2ger (⌚ UTC+1/+2) 2012-06-06 05:22:49 PDT
Created attachment 630523 [details] [diff] [review]
Patch v1
Comment 1 :Ehsan Akhgari 2012-06-06 08:11:16 PDT
Comment on attachment 630523 [details] [diff] [review]
Patch v1

Review of attachment 630523 [details] [diff] [review]:
-----------------------------------------------------------------

::: editor/libeditor/html/nsHTMLEditRules.cpp
@@ +737,3 @@
>        // need to look inside dl and see which types of items it has
>        bool bDT, bDD;
> +      GetDefinitionListItemTypes(element, bDT, bDD);

Does this compile?  ;)  You should be passing pointers to the bools here.
Comment 2 :Ms2ger (⌚ UTC+1/+2) 2012-06-17 07:16:14 PDT
https://hg.mozilla.org/mozilla-central/rev/29f38048200e

Note You need to log in before you can comment on or make changes to this bug.