Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Cleanup nsHTMLEditRules::GetListItemState / nsHTMLEditRules::GetDefinitionListItemTypes

RESOLVED FIXED in mozilla16

Status

()

Core
Editor
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

Trunk
mozilla16
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 630523 [details] [diff] [review]
Patch v1
Attachment #630523 - Flags: review?(ehsan)
Comment on attachment 630523 [details] [diff] [review]
Patch v1

Review of attachment 630523 [details] [diff] [review]:
-----------------------------------------------------------------

::: editor/libeditor/html/nsHTMLEditRules.cpp
@@ +737,3 @@
>        // need to look inside dl and see which types of items it has
>        bool bDT, bDD;
> +      GetDefinitionListItemTypes(element, bDT, bDD);

Does this compile?  ;)  You should be passing pointers to the bools here.
Attachment #630523 - Flags: review?(ehsan) → review+
(Assignee)

Comment 2

5 years ago
https://hg.mozilla.org/mozilla-central/rev/29f38048200e
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
You need to log in before you can comment on or make changes to this bug.