762015 - Checkboxes in inline preferences don't fire the command event

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect)

Description

[Wladimir Palant]

Adblock Plus uses inline preferences that aren't bound to a preference - a "command" event handler is being attached instead when the inline preferences open. This works fine in desktop Firefox and XUL Fennec but fails in the native Fennec. Looking at the code, the issue is apparently this line:

> http://hg.mozilla.org/mozilla-central/file/a6c39a15557b/mobile/android/chrome/content/bindings/settings.xml#l25

fireEvent("oncommand") will merely eval the value of the "oncommand" attribute, it won't dispatch an actual "command" event. In fact, it will pass in an event with wrong type "oncommand" to the function. The work-around is adding this oncommand attribute to the <setting> tag:

> oncommand="if (event.type == 'oncommand') {event = document.createEvent('Events'); event.initEvent('command', true, true); this.dispatchEvent(event);}"

Comment 1

[Aaron Train [:aaronmt]]

Is this still an issue?

Comment 2

[Wladimir Palant]

Yes, nothing changed since I filed that bug. Current code will still call fireEvent("oncommand") which merely evals the oncommand attribute but doesn't actually trigger listeners for the "command" event.

Comment 3

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.