762046 - Amazon search-plugin hard-coded for desktop site; they send us mobile

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aaron Train [:aaronmt]]

Currently our Amazon search-plugin is hard-coded to send queries to their desktop site. While visiting Amazon manually sends us their mobile site (ie., Amazon.com redirects to http://www.amazon.com/gp/aw/h.html)

Example search: http://www.amazon.com/gp/aw/s/ref=is_box_?k=Sony

http://mxr.mozilla.org/mozilla-central/source/browser/locales/en-US/searchplugins/amazondotcom.xml

Comment 1

[Aaron Train [:aaronmt]]

Any chance of getting a fix in for this?

Comment 2

[Axel Hecht [:Pike]]

I guess this has partnership impact, Kev?

Comment 3

[Kev Needham [:kev]]

Will need to coordinate with Amazon. I'll bring this up with Joanne and see what we should be including as a plugin.

Comment 4

[Lawrence Mandel [:lmandel] (use needinfo)]

We own the code for the search plug-in and Aaron has provided an example mobile search URL. Can we make the update with this information? What help do we need from Amazon?

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

I think we need the official URL Amazon would like us to use. We are currently using the same URL as Desktop Firefox uses.

Comment 6

[Lawrence Mandel [:lmandel] (use needinfo)]

(In reply to Mark Finkle (:mfinkle) from comment #5)
> I think we need the official URL Amazon would like us to use. We are
> currently using the same URL as Desktop Firefox uses.

Is this for tracking/partnership? Can we update the search plug-in to the URL that Aaron suggests to produce a good user experience now and update the URL again once we have an official one from Amazon?

Comment 7

[Joanne Nagel]

I have contacted Amazon and will update the bug as soon as I get a response.

Comment 8

[Joanne Nagel]

I am still working on this, hope to have an answer by Wed. (7/18).  Thanks, Joanne

Comment 9

[Joanne Nagel]

I emailed them again yesterday asking for a contact to assist - no response so far.

Comment 10

[Joanne Nagel]

I have been pushing on this regularly.  I have a commitment from my contact to provide an update and/or solution by end of day Wed. (8/1)

Comment 11

[Mark Finkle (:mfinkle) (use needinfo?)]

Any update?

Comment 12

[Joanne Nagel]

No, I have sent another request - our meetings have been rescheduled and cancelled the past 2 weeks.

Comment 13

[Lawrence Mandel [:lmandel] (use needinfo)]

Do we have any data on how many people are using the built in Amazon search option? If there are a significant number of users for this search integration, can we revisit providing them a good experience now with the mobile search URL that Aaron provided in the description until we get the official URL from Amazon?

Comment 14

[Axel Hecht [:Pike]]

We're generally not adding hooks to 3rd parties without their consent, as we want to be sure that the hardware on the other side is built out to handle the load etc. Not saying that this is a big problem in this case, but it's also hard to rule out from the outside.

Comment 15

[Joanne Nagel]

Hi,

Finally got a response from Amazon, they would prefer that we use:  http://m.amazon.com

Let me know if there is anything else...

Thanks,
Joanne

Comment 16

[Kevin Brosnan [Ex-Mozilla]]

(In reply to Joanne Nagel from comment #15)
> Hi,
> 
> Finally got a response from Amazon, they would prefer that we use: 
> http://m.amazon.com
> 

Does this include tablet devices?

Comment 17

[Brad Lassey [:blassey] (use needinfo?)]

renom'ing based on new information

Comment 18

[Mark Finkle (:mfinkle) (use needinfo?)]

Using the non-desktop, non-mobile URL seems to send us to desktop for tablets and mobile for phones. Let's use that URL.

Comment 19

[Aaron Train [:aaronmt]]

http://www.amazon.com

Phones - Amazon (mobile)
Tablet 7" - Amazon (deskop)
Tablet 10" - Amazon (desktop)

Comment 20

[Joanne Nagel]

Hi,

Finally received confirmation that m.amazon.com should be used for tablets as well.  Is this an issue?  Can we close this bug now?

Thanks,
Joanne

Comment 21

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

This patch uses: http://m.amazon.com/gp/aw/s&k={searchterm}

This means we will get mobile search results on tablets

Comment 22

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 685270 [details] [diff] [review]
patch

>+          dump("**** search engine url: " + url)

Oops. I'll remove this.

Comment 23

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Mark Finkle (:mfinkle) from comment #21)
> Created attachment 685270 [details] [diff] [review]
> patch
> 
> This patch uses: http://m.amazon.com/gp/aw/s&k={searchterm}

http://m.amazon.com/gp/aw/s?k={searchterm}

Comment 24

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/072afb032cce

Comment 25

[Aaron Train [:aaronmt]]

Channel nom?

Comment 26

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 685270 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: Desktop search UI on phones
Testing completed (on m-c, etc.): landed on m-c
Risk to taking this patch (and alternatives if risky): fairly small. limited to amazon search only
String or UUID changes made by this patch: none

Comment 27

[Alex Keybl [:akeybl]]

Seems like a low risk change - adding qawanted/verifyme to verify that we don't have any regressions around localized build behavior.

Comment 28

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/dca3546b6437
https://hg.mozilla.org/releases/mozilla-beta/rev/e8b696e40f36

Comment 29

[Lukas Blakk [:lsblakk] use ?needinfo]

We don't release ESR mobile so wontfixing for esr17.