762109 - Reader Mode: Android Sync support

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: Android Sync, defect, P2)

Description

[Richard Newman [:rnewman]]

This is a backward-compatible extension to the bookmark record format.

Bookmarks in Fennec have a "display" column (defined in the class "BrowserContract.Combined"):

    1.38 +        public static final int DISPLAY_NORMAL = 0;
    1.39 +        public static final int DISPLAY_READER = 1;

    1.43 +        public static final String DISPLAY = "display";

and we have a new root with a new magic GUID:

    1.20 +        public static final String READING_LIST_FOLDER_GUID = "readinglist";

This bug tracks adding support for these to Android Sync.

Comment 1

[Richard Newman [:rnewman]]

See Bug 762108 for the desktop side of this.

Comment 2

[Richard Newman [:rnewman]]

lucasr, mfinkle: is this something we can leave until Bug 745408 washes over us like a wave (October or later?), or should we explore solutions now?

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Richard Newman [:rnewman] from comment #2)
> lucasr, mfinkle: is this something we can leave until Bug 745408 washes over
> us like a wave (October or later?), or should we explore solutions now?

Probably. We also need Reader for Desktop working for this to be useful in Sync. That work is starting soon.

Comment 4

[Nick Alexander :nalexander [he/him]]

(In reply to Mark Finkle (:mfinkle) from comment #3)
> (In reply to Richard Newman [:rnewman] from comment #2)
> > lucasr, mfinkle: is this something we can leave until Bug 745408 washes over
> > us like a wave (October or later?), or should we explore solutions now?
> 
> Probably. We also need Reader for Desktop working for this to be useful in
> Sync. That work is starting soon.

I want to make sure we don't lose this: is this still work in progress?

Comment 5

[Lucas Rocha (:lucasr)]

(In reply to Nick Alexander :nalexander from comment #4)
> (In reply to Mark Finkle (:mfinkle) from comment #3)
> > (In reply to Richard Newman [:rnewman] from comment #2)
> > > lucasr, mfinkle: is this something we can leave until Bug 745408 washes over
> > > us like a wave (October or later?), or should we explore solutions now?
> > 
> > Probably. We also need Reader for Desktop working for this to be useful in
> > Sync. That work is starting soon.
> 
> I want to make sure we don't lose this: is this still work in progress?

Students are still working on the front-end bits of reader mode on desktop. It will take some time until they actually start dealing with reading list, Places, and sync. I'd probably wait until reader mode is functional on desktop (on an alpha-level even).

Comment 6

[Richard Newman [:rnewman]]

(In reply to Lucas Rocha (:lucasr) from comment #5)

> Students are still working on the front-end bits of reader mode on desktop.
> It will take some time until they actually start dealing with reading list,
> Places, and sync. I'd probably wait until reader mode is functional on
> desktop (on an alpha-level even).

Out of interest, is this making progress, and does it have a bug #?

Comment 7

[Lucas Rocha (:lucasr)]

(In reply to Richard Newman [:rnewman] from comment #6)
> (In reply to Lucas Rocha (:lucasr) from comment #5)
> 
> > Students are still working on the front-end bits of reader mode on desktop.
> > It will take some time until they actually start dealing with reading list,
> > Places, and sync. I'd probably wait until reader mode is functional on
> > desktop (on an alpha-level even).
> 
> Out of interest, is this making progress, and does it have a bug #?

I need to talk with Jared about our plan for reader in desktop Firefox. The current patch (can't find the bug number right now) needs work before landing I think.

Comment 8

[Richard Newman [:rnewman]]

WONTFIX in favor of Bug 1082011.