762128 - JavaScript Error: "cpmm is null" {file: "file:///Volumes/mac/code/2/build/dist/B2GDebug.app/Contents/MacOS/components/SettingsManager.js" line: 277

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Gregor Wagner [:gwagner]]

In a debug b2g desktop build during startup I see
************************************************************
* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "'[JavaScript Error: "cpmm is null" {file: "file:///Volumes/mac/code/2/build/dist/B2GDebug.app/Contents/MacOS/components/SettingsManager.js" line: 277}]' when calling method: [nsIObserver::observe]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0"  data: yes]
************************************************************
************************************************************
* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "'[JavaScript Error: "cpmm is null" {file: "file:///Volumes/mac/code/2/build/dist/B2GDebug.app/Contents/MacOS/components/SettingsManager.js" line: 277}]' when calling method: [nsIObserver::observe]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0"  data: yes]
************************************************************
************************************************************
* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "'[JavaScript Error: "cpmm is null" {file: "file:///Volumes/mac/code/2/build/dist/B2GDebug.app/Contents/MacOS/components/SettingsManager.js" line: 277}]' when calling method: [nsIObserver::observe]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0"  data: yes]
************************************************************
************************************************************
* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "'[JavaScript Error: "cpmm is null" {file: "file:///Volumes/mac/code/2/build/dist/B2GDebug.app/Contents/MacOS/components/SettingsManager.js" line: 277}]' when calling method: [nsIObserver::observe]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0"  data: yes]
************************************************************

Comment 1

[Gregor Wagner [:gwagner]]

So one solution is to remove the line https://mxr.mozilla.org/mozilla-central/source/dom/settings/SettingsManager.js#283
cpmm is shared here. We also don't set cpmm to null in the DOMRequestHelper.
The only quesiton is if this would cause a leak.

Comment 2

[Gregor Wagner [:gwagner]]

After a discussion with mrbkap we decided that it's best to just remove the cpmm = null. It shouldn't leak.

Comment 3

[Christoph Kerschbaumer [:ckerschb}]

Attachment: followed gwagner's advice and removed cpmm = null;

Comment 4

[Gregor Wagner [:gwagner]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8d2d761e98cc

Comment 5

[Philipp von Weitershausen [:philikon]]

(In reply to Gregor Wagner [:gwagner] from comment #2)
> After a discussion with mrbkap we decided that it's best to just remove the
> cpmm = null. It shouldn't leak.

I have evidence that suggests (not proves) otherwise: https://bugzilla.mozilla.org/show_bug.cgi?id=734018#c7

Comment 6

[Gregor Wagner [:gwagner]]

(In reply to Philipp von Weitershausen [:philikon] from comment #5)
> (In reply to Gregor Wagner [:gwagner] from comment #2)
> > After a discussion with mrbkap we decided that it's best to just remove the
> > cpmm = null. It shouldn't leak.
> 
> I have evidence that suggests (not proves) otherwise:
> https://bugzilla.mozilla.org/show_bug.cgi?id=734018#c7

mrbkap mentioned that we include many services like that and they don't leak.

Comment 7

[Graeme McCutcheon [:graememcc]]

https://hg.mozilla.org/mozilla-central/rev/8d2d761e98cc

(Merged by Ed Morley)