JavaScript Error: "cpmm is null" {file: "file:///Volumes/mac/code/2/build/dist/B2GDebug.app/Contents/MacOS/components/SettingsManager.js" line: 277

RESOLVED FIXED in mozilla16

Status

()

Core
DOM: Device Interfaces
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: gwagner, Assigned: ckerschb)

Tracking

unspecified
mozilla16
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
In a debug b2g desktop build during startup I see
************************************************************
* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "'[JavaScript Error: "cpmm is null" {file: "file:///Volumes/mac/code/2/build/dist/B2GDebug.app/Contents/MacOS/components/SettingsManager.js" line: 277}]' when calling method: [nsIObserver::observe]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0"  data: yes]
************************************************************
************************************************************
* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "'[JavaScript Error: "cpmm is null" {file: "file:///Volumes/mac/code/2/build/dist/B2GDebug.app/Contents/MacOS/components/SettingsManager.js" line: 277}]' when calling method: [nsIObserver::observe]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0"  data: yes]
************************************************************
************************************************************
* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "'[JavaScript Error: "cpmm is null" {file: "file:///Volumes/mac/code/2/build/dist/B2GDebug.app/Contents/MacOS/components/SettingsManager.js" line: 277}]' when calling method: [nsIObserver::observe]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0"  data: yes]
************************************************************
************************************************************
* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "'[JavaScript Error: "cpmm is null" {file: "file:///Volumes/mac/code/2/build/dist/B2GDebug.app/Contents/MacOS/components/SettingsManager.js" line: 277}]' when calling method: [nsIObserver::observe]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0"  data: yes]
************************************************************
(Reporter)

Updated

5 years ago
Blocks: 753862
(Reporter)

Comment 1

5 years ago
So one solution is to remove the line https://mxr.mozilla.org/mozilla-central/source/dom/settings/SettingsManager.js#283
cpmm is shared here. We also don't set cpmm to null in the DOMRequestHelper.
The only quesiton is if this would cause a leak.
(Reporter)

Comment 2

5 years ago
After a discussion with mrbkap we decided that it's best to just remove the cpmm = null. It shouldn't leak.
(Reporter)

Updated

5 years ago
Assignee: nobody → mozilla
(Assignee)

Comment 3

5 years ago
Created attachment 630749 [details] [diff] [review]
followed gwagner's advice and removed cpmm = null;
(Assignee)

Updated

5 years ago
Attachment #630749 - Flags: review?(fabrice)
Attachment #630749 - Flags: review?(fabrice) → review+
(Reporter)

Comment 4

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/8d2d761e98cc
(In reply to Gregor Wagner [:gwagner] from comment #2)
> After a discussion with mrbkap we decided that it's best to just remove the
> cpmm = null. It shouldn't leak.

I have evidence that suggests (not proves) otherwise: https://bugzilla.mozilla.org/show_bug.cgi?id=734018#c7
(Reporter)

Comment 6

5 years ago
(In reply to Philipp von Weitershausen [:philikon] from comment #5)
> (In reply to Gregor Wagner [:gwagner] from comment #2)
> > After a discussion with mrbkap we decided that it's best to just remove the
> > cpmm = null. It shouldn't leak.
> 
> I have evidence that suggests (not proves) otherwise:
> https://bugzilla.mozilla.org/show_bug.cgi?id=734018#c7

mrbkap mentioned that we include many services like that and they don't leak.
https://hg.mozilla.org/mozilla-central/rev/8d2d761e98cc

(Merged by Ed Morley)
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
You need to log in before you can comment on or make changes to this bug.