Closed Bug 762155 Opened 7 years ago Closed 7 years ago

bookmark keywords do not work (search bookmark keywords do)

Categories

(Firefox for Android :: General, defect)

ARM
Android
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 19
Tracking Status
firefox17 --- affected
firefox18 --- affected
firefox19 --- verified
blocking-fennec1.0 --- -
fennec + ---

People

(Reporter: kbrosnan, Assigned: bnicholson)

Details

Attachments

(1 file)

open mobile Nightly
click in the address bar
select bookmarks
long tap on a bookmark
select edit
set the keyword to a
type a in the address bar

expected results
* keyword bookmark is opened

Broken on beta as well.
actual results
* google search for a
Is this bug 736593, which is still open?
tracking-fennec: --- → 15+
blocking-fennec1.0: ? → -
No, your bug is about showing the matches in the awesome screen. Mine is about matching XUL Fennec/desktop behavior.
Assignee: nobody → bnicholson
tracking-fennec: 15+ → +
(In reply to Kevin Brosnan [:kbrosnan] from comment #2)
> No, your bug is about showing the matches in the awesome screen. Mine is
> about matching XUL Fennec/desktop behavior.

In this case, I guess that if the characters typed in URL Bar will match with any existing keywords, then instead of the magnifying glass button (both in URL Bar and VKB), the arrow should be displayed in URL Bar and GO on VKB.
We only look up the keyword URL if the user is doing a keyword search. This patch allows using keywords even if no search term is given.
Attachment #670477 - Flags: review?(mark.finkle)
Attachment #670477 - Flags: review?(mark.finkle) → review+
https://hg.mozilla.org/mozilla-central/rev/4e4d69f5abf5
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 19
Flags: in-moztrap?(nicolae.cristian)
Typing in URL Bar a saved keyword and pressing enter, will open the according bookmark. 

Closing bug as verified fixed on:

Firefox 19.0a1 (2012-11-15)
Device: Galaxy S2
OS: Android 4.0.3
Status: RESOLVED → VERIFIED
I've added a couple of testcases for this feature:

https://moztrap.mozilla.org/manage/case/4167/

https://moztrap.mozilla.org/manage/case/4166/
Flags: in-moztrap?(nicolae.cristian) → in-moztrap+
You need to log in before you can comment on or make changes to this bug.