762155 - bookmark keywords do not work (search bookmark keywords do)

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Kevin Brosnan [Ex-Mozilla]]

open mobile Nightly
click in the address bar
select bookmarks
long tap on a bookmark
select edit
set the keyword to a
type a in the address bar

expected results
* keyword bookmark is opened

Broken on beta as well.
actual results
* google search for a

Comment 1

[Aaron Train [:aaronmt]]

Is this bug 736593, which is still open?

Comment 2

[Kevin Brosnan [Ex-Mozilla]]

No, your bug is about showing the matches in the awesome screen. Mine is about matching XUL Fennec/desktop behavior.

Comment 3

[Cristian Nicolae (:xti)]

(In reply to Kevin Brosnan [:kbrosnan] from comment #2)
> No, your bug is about showing the matches in the awesome screen. Mine is
> about matching XUL Fennec/desktop behavior.

In this case, I guess that if the characters typed in URL Bar will match with any existing keywords, then instead of the magnifying glass button (both in URL Bar and VKB), the arrow should be displayed in URL Bar and GO on VKB.

Comment 4

[Brian Nicholson (:bnicholson)]

Attachment: Open keyword URLs without a search term

We only look up the keyword URL if the user is doing a keyword search. This patch allows using keywords even if no search term is given.

Comment 5

[Brian Nicholson (:bnicholson)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/4e4d69f5abf5

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4e4d69f5abf5

Comment 7

[Cristian Nicolae (:xti)]

Typing in URL Bar a saved keyword and pressing enter, will open the according bookmark. 

Closing bug as verified fixed on:

Firefox 19.0a1 (2012-11-15)
Device: Galaxy S2
OS: Android 4.0.3

Comment 8

[Cristian Nicolae (:xti)]

I've added a couple of testcases for this feature:

https://moztrap.mozilla.org/manage/case/4167/

https://moztrap.mozilla.org/manage/case/4166/