76223 - The mozilla installer script should be runnable from absolute/relative path

Status: RESOLVED FIXED

(SeaMonkey :: Installer, defect)

Description

[Girish Manwani]

Currently the mozilla-installer is run by doing the foloowing ..

cd /directory/of/installer
./mozilla-installer

the user should be able to do the following
/directory/of/installer/mozilla-installer

to install the application

Comment 1

[Samir Gehani]

Reassiginging to Girish.  I'd like to review the patch.  Thanks.

Comment 2

[Girish Manwani]

Attachment: patch to make installer runnable from anywhere

Comment 3

[Girish Manwani]

Attachment: Patch for nstree, netscape-installer script

Comment 4

[Samir Gehani]

r=sgehani

Comment 5

[Girish Manwani]

sr= needed for mozilla-installer patch to be runnable from amywhere and also 
check for DISPLAY environment variable before launching. patch fixes 76223 and 
76224.

Comment 6

[André Langhorst]

adding patch keyword

Comment 7

[Alec Flett]

I don't think we should be checking for DISPLAY - the toolkit already does the
check, why should we do our own check?

Comment 8

[Girish Manwani]

why should you load the binary/libraries etc. at all ?? This is an environment
setting and i think the correct behaviour is to check for this setting before
loading the binary itself and if the test fails inform the user. Since it is an
enhancement & relatively trivial i thought might as well put it in(actual bug
no. 76224) with the bug fix for 76223. thanks

Comment 9

[Alec Flett]

because the binary already checks for it, and outputs an error. Why put it in
the script? we don't check to make sure the profile directory exists either,
because the binary checks for us..

it simply adds unnecessary complexity to this startup script

Comment 10

[Girish Manwani]

Alec if thats how you feel .. i can't really do much :)... In my opinion this is
really a no brainer, it does not seem that the script gets really a lot more
complicated it is just an additional env. variable check. More so i believe it
is always better to be as self-sufficient as possible(especially in case of
installers). 

Comment 11

[Samir Gehani]

Girish, 
I think what Alec is saying here is that the DISPLAY check really adds no value
since the user will see a GDK error, anyways, if the display can't be opened. 
Now, if on the other hand you found DISPLAY was not set and tried some sensible
default (don't know what would be considered senseible: maybe DISPLAY=:0.0) then
this check may be worth it.  What does the 'mozilla' shell script do?

I concur with Alec: please change the script to either set DISPLAY to a sensible
default or to not check it at all.  Thanks.

Comment 12

[Alec Flett]

if DISPLAY is not set, then no X applications will work, and no other X 
applications that I know of will try :0.0 either, so we should do NOTHING with 
the DISPLAY environment variable. Why this obsession over DISPLAY? We don't 
check for HOME in the script, and the binary will barf if that's not set, or is 
set incorrectly..

Comment 13

[Girish Manwani]

Thanx for clarifying samir. Even the 'mozilla' shell script does not check for
it .. relies on the toolkit. If alec/samir you think it is worth checking
display and then setting to a default we can do that or i am happy to remove the
check. sorry for the misunderstanding.

Comment 14

[Samir Gehani]

Remove the check and r=sgehani.  

Comment 15

[Girish Manwani]

Attachment: Patch removes the DISPLAY env variable check, makes installer runnable from anywhere

Comment 16

[Alec Flett]

sr=alecf

Comment 17

[Girish Manwani]

Hi samir,
could you please check this in. Also, go ahead and close 76224 as "not a bug" or
"will not fix" either ways. thanks a lot.

Comment 18

[Girish Manwani]

samir/alecf can one of you please check this in. thanks.

Comment 19

[Girish Manwani]

Attachment: Equivalent nstree patch...

Comment 20

[Alec Flett]

sr=alecf on that too.. I'll try to check in today.

Comment 21

[Girish Manwani]

Thanks a lot alec !! could you please check-in 66688 too.. sr= was by you again
:)

Comment 22

[drapeau]

alecf: will you be able to check in soon?  Girish is young, looking for bug fix
credits anywhere he can get them.  :-)

Comment 23

[Asa Dotzler [:asa]]

a= [e-mail] for checkin to the trunk.
(on behalf of drivers)

Comment 24

[Girish Manwani]

Fix checked in. Thanks Asa for your auick qpproval.

Comment 25

[Girish Manwani]

Fix checked in. Thanks Asa for your quick approval.

Comment 26

[Grace Bush]

I can verify this for mozilla build 2001072004 
using command /u/gbush/path/mozilla-installer

I cannot get it to work for Netscape   6 Installer.
using the command /u/gbush/path/netscape-installer

error message is ./netscape-installer-bin: No such file or directory

Comment 27

[Girish Manwani]

I have reverified this on trunk build from today 07/26/2001 and it works just
fine. i could run it with a complete absolute path ...
could you please re-verify this grace ? thanx

Comment 28

[Girish Manwani]

No longer working on Mozilla.

Comment 29

[Sean Su]

over to dprice.

Comment 30

[chris hofmann]

dprice is on sabitcal. moving to next milestone. 

Comment 31

[Syd Logan]

only nsbeta1+ bugs can have milestones, resetting to ---

Comment 32

[Andrew Schultz]

this was FIXED a long time ago.
resolving as such.