Closed Bug 762357 Opened 12 years ago Closed 12 years ago

moz2-darwin slaves still being used for mozilla-beta and comm-beta repacks

Categories

(Release Engineering :: Release Automation: Other, defect)

Product:
Release Engineering
Component:
Release Automation: Other
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: nthomas, Assigned: catlee)

References

Details

Attachments

(1 file, 3 obsolete files)

use l10n_slaves_key
2.59 KB, patch
bhearsum
: review+
catlee
: checked-in+
Details | Diff | Splinter Review 
I was expecting to see bld-lion-r5 assigned of moz2-darwin10. This *may* be OK for mac, because it's not like windows where are compiling localised executables, but we should confirm that. Both Firefox 14.0b6 and Thunderbird 14.0b1 are affected.
Attached patch patch suggested by catlee (obsolete) — — Splinter Review 

        Attachment #630968 -
        Flags: review?(catlee)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        fixed typo in patch (obsolete)
        — 
          — Splinter Review
      

    


  

        Attachment #630968 -
        Attachment is obsolete: true

        Attachment #630968 -
        Flags: review?(catlee)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        fixed patch (obsolete)
        — 
          — Splinter Review
      

    


  

        Attachment #630971 -
        Attachment is obsolete: true

        Attachment #630973 -
        Flags: review?(catlee)

    
    

    
  


  
turns out that we can't override l10n_slaves from config.py, so we have to teach process/release.py to use l10n_slaves_key.

        Attachment #630973 -
        Attachment is obsolete: true

        Attachment #630973 -
        Flags: review?(catlee)

        Attachment #630989 -
        Flags: review?(bhearsum)

    
    

    
  
Comment on attachment 630989 [details] [diff] [review]
use l10n_slaves_key

Review of attachment 630989 [details] [diff] [review]:
-----------------------------------------------------------------

I hate our configs.

        Attachment #630989 -
        Flags: review?(bhearsum) → review+

    
  

        Attachment #630989 -
        Flags: checked-in+
Assignee: nobody → catlee

    
    

    
  
This landed in production today.

    
  
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: