The default bug view has changed. See this FAQ.

Refactor omx plugin's ReadVideo method

RESOLVED FIXED in mozilla16

Status

()

Core
Audio/Video
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: cajbir, Assigned: cajbir)

Tracking

Trunk
mozilla16
ARM
Gonk (Firefox OS)
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
The ReadVideo method of OMXPlugin uses an infinite 'for' loop with conditionals to break or continue. This makes the control flow hard to follow and should be refactored so the infinite loop is not needed.
(Assignee)

Updated

5 years ago
Assignee: nobody → chris.double
Status: NEW → ASSIGNED
(Assignee)

Comment 1

5 years ago
Created attachment 631217 [details] [diff] [review]
Refactored method
Attachment #631217 - Flags: review?(eflores)
Attachment #631217 - Flags: review?(eflores) → review+
(Assignee)

Comment 2

5 years ago
Needs bug 761762 landed first, waiting for that to be ready before checkin-needed on this.
Depends on: 761762
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/2fd06ff2ed50
Target Milestone: --- → mozilla16

Updated

5 years ago
Whiteboard: [inbound]
https://hg.mozilla.org/mozilla-central/rev/2fd06ff2ed50

(Merged by Ed Morley)
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
You need to log in before you can comment on or make changes to this bug.