replace do_QueryObject() with static cast in CAccessibleEditableText

RESOLVED FIXED in mozilla16

Status

()

Core
Disability Access APIs
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: tbsaunde, Assigned: drexler)

Tracking

unspecified
mozilla16
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug][mentor=trev.saunders@gmail.com][lang=c++])

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

5 years ago
similar to bug 762394
(Assignee)

Comment 1

5 years ago
Created attachment 633201 [details] [diff] [review]
patch

passed all tests locally.
Assignee: nobody → andrew.quartey
Status: NEW → ASSIGNED
Attachment #633201 - Flags: review?(trev.saunders)
(Reporter)

Comment 2

5 years ago
Comment on attachment 633201 [details] [diff] [review]
patch

> #include "HyperTextAccessible.h"
>+#include "HyperTextAccessibleWrap.h"

the second neccessarily includes the first, so only include the second.

> CAccessibleEditableText::copyText(long aStartOffset, long aEndOffset)
> {
> __try {
>-  nsRefPtr<HyperTextAccessible> textAcc(do_QueryObject(this));
>-  if (textAcc->IsDefunct())
>+  HyperTextAccessible* ia2AccessibleText = static_cast<HyperTextAccessibleWrap*>(this);

uh, I meant rename the class, not the variables, so CAccessibleEditableText is what should be changed to ia2AccessibleEditableText


otherwise seems fine.
Attachment #633201 - Flags: review?(trev.saunders)
(Assignee)

Comment 3

5 years ago
Created attachment 633351 [details] [diff] [review]
patch

Updated patch addressing comments.
Attachment #633201 - Attachment is obsolete: true
Attachment #633351 - Flags: review?(trev.saunders)
(Reporter)

Comment 4

5 years ago
Comment on attachment 633351 [details] [diff] [review]
patch

>+ia2AccessibleEditableText::copyText(long aStartOffset, long aEndOffset)

nit, same issue here and below were you break alignment.
Attachment #633351 - Flags: review?(trev.saunders) → review+
(Assignee)

Comment 5

5 years ago
Created attachment 633550 [details] [diff] [review]
updated_patch

Updated patch addressing nits.
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/25ca50ce8653
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/25ca50ce8653
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
You need to log in before you can comment on or make changes to this bug.