Last Comment Bug 762430 - warning: ‘res’ may be used uninitialized in nsHTMLAbsPosition.cpp
: warning: ‘res’ may be used uninitialized in nsHTMLAbsPosition.cpp
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Editor (show other bugs)
: Trunk
: All All
: -- trivial (vote)
: mozilla16
Assigned To: Aryeh Gregor (:ayg) (away until October 25)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-06-07 04:10 PDT by Aryeh Gregor (:ayg) (away until October 25)
Modified: 2012-06-08 04:21 PDT (History)
1 user (show)
ayg: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v1 (2.99 KB, patch)
2012-06-07 06:28 PDT, Aryeh Gregor (:ayg) (away until October 25)
ehsan: review+
Details | Diff | Splinter Review

Description Aryeh Gregor (:ayg) (away until October 25) 2012-06-07 04:10:42 PDT
/mnt/extra/checkouts/mozilla-central/editor/libeditor/html/nsHTMLAbsPosition.cpp: In member function ‘virtual nsresult nsHTMLEditor::AbsolutelyPositionElement(nsIDOMElement*, bool)’:
/mnt/extra/checkouts/mozilla-central/editor/libeditor/html/nsHTMLAbsPosition.cpp:492:12: warning: ‘res’ may be used uninitialized in this function [-Wuninitialized]
Comment 1 Aryeh Gregor (:ayg) (away until October 25) 2012-06-07 06:28:09 PDT
Created attachment 630946 [details] [diff] [review]
Patch v1

FWIW, the warning looks legit: res will be returned uninitialized if aEnabled && parentNode->GetChildCount() != 1.  Try: https://tbpl.mozilla.org/?tree=Try&rev=698df2d0749b
Comment 2 Aryeh Gregor (:ayg) (away until October 25) 2012-06-07 08:01:56 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/3e12ea5cc535
Comment 3 Graeme McCutcheon [:graememcc] 2012-06-08 04:21:55 PDT
https://hg.mozilla.org/mozilla-central/rev/3e12ea5cc535

(Merged by Ed Morley)

Note You need to log in before you can comment on or make changes to this bug.