Last Comment Bug 762436 - Get rid of the nsresult return value for nsIXPCScriptable::GetScriptableFlags()
: Get rid of the nsresult return value for nsIXPCScriptable::GetScriptableFlags()
Product: Core
Classification: Components
Component: XPConnect (show other bugs)
: Trunk
: All All
-- normal (vote)
: mozilla16
Assigned To: :Ms2ger (⌚ UTC+1/+2)
: Andrew Overholt [:overholt]
Depends on:
  Show dependency treegraph
Reported: 2012-06-07 04:37 PDT by :Ms2ger (⌚ UTC+1/+2)
Modified: 2012-06-17 07:16 PDT (History)
2 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Patch v1 (9.16 KB, patch)
2012-06-07 04:37 PDT, :Ms2ger (⌚ UTC+1/+2)
mrbkap: review+
Details | Diff | Splinter Review

Description User image :Ms2ger (⌚ UTC+1/+2) 2012-06-07 04:37:58 PDT
Created attachment 630922 [details] [diff] [review]
Patch v1

Comment 1 User image Bobby Holley (:bholley) (busy with Stylo) 2012-06-07 05:27:25 PDT
Comment on attachment 630922 [details] [diff] [review]
Patch v1

Peter and I weren't sure whether we wanted this change given the potential breakage to embedders who might be using it (are there any?). Escalating to blake.

Also, needs an IID rev.
Comment 2 User image Blake Kaplan (:mrbkap) 2012-06-07 13:17:24 PDT
Comment on attachment 630922 [details] [diff] [review]
Patch v1

Review of attachment 630922 [details] [diff] [review]:

I say we go for it... We don't know of any XPConnect users from C++, and the IID change should save them from getting shot in the foot (it is unfortunate the nsresult and PRUint32 are the same type, but there isn't much we can do about it). This has also been bothering me for a long time so I'm super happy to see it go.

::: js/xpconnect/idl/nsIXPCScriptable.idl
@@ +79,5 @@
>      // with this bit set.
>      const PRUint32 RESERVED                         = 1 << 31;
>      readonly attribute string   className;
> +    [notxpcom,noscript,nostdcall] PRUint32 getScriptableFlags();

No need for noscript here: the entire interface is noscript.

Also, as you noted, this needs an IID rev.

On a related note: is there any reason to keep this interface in IDL? Since we already have xpc_map_end.h the autogenerated macros don't seem terribly useful...
Comment 3 User image :Ms2ger (⌚ UTC+1/+2) 2012-06-17 07:16:45 PDT

Note You need to log in before you can comment on or make changes to this bug.