76253 - Page source of an attached image can not be viewed

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[marina]

**** observed with 2001-04-16 build ****
Steps to reproduce:
- attach an image file to the message;
- get message, open the attachment from the envelope in the browser;
- go View|Page source;
//note: page source is blank and browser tries to open/save the attachment again

Comment 1

[marina]

Attachment: attach the image and open it in the browser from the envelope

Comment 2

[Malcolm Rowe]

This sounds like the same problem as bug 84542.

Comment 3

[[e-mail]]

I've got a patch that adds a "View Source" item to the attachment menus,
if you're interested.

Comment 4

[[e-mail]]

Attachment: Proposed patch

I got a bit carried away...
* Added View Source to all attachment menus
* Added a special menu for a single attachment
* Created the attachment submenus lazily
* Removed individual command handlers
* Rewrote the backend not to use eval

Comment 5

[[e-mail]]

Attachment: Rest of patch :-)

Comment 6

[[e-mail]]

Attachment: bitrot

Comment 7

[[e-mail]]

Attachment: bitrot

Comment 8

[Malcolm Scott]

This sounds like a dupe of bug 84542 to me.

Comment 9

[[e-mail]]

No, my patch correctly views the page source of any attachment in the list.

Comment 10

[Wayne Mery (:wsmwk)]

(In reply to comment #0)
> **** observed with 2001-04-16 build ****
> Steps to reproduce:
> - attach an image file to the message;
> - get message, open the attachment from the envelope in the browser;
> - go View|Page source;
> //note: page source is blank and browser tries to open/save the attachment again

why would it not be blank? 

view source displays attachment source in mail front end.
so is this bug still needed?

Comment 11

[[e-mail]]

Well I guess the underlying bug is WORKSFORME these days and parts of the patch have already been checked in although I still find it convenient to be able to view the source of a file that has been attached with the wrong MIME type. Mnyromyr, do you think I should resurrect any parts of comment 4?

Comment 12

[Karsten Düsterloh]

The original bug description as such is WFM now, since you can't do "View|Page source" anymore in this particular case...

But in the case of mail attachments it's still useful to able to see the decoded source, so a View Source (context) menuitem would be a nice-to-have.

Comment 13

[[e-mail]]

Attachment: Proposed patch

* Adds a view source menuitem to the context menu
* Creates the file attachment submenus lazily
* Clones the context menuitems to save duplication on entities
* Makes deleted attachments display in the file submenu
* Fixes a strict JS warning

Comment 14

[Karsten Düsterloh]

Comment on attachment 207916 [details] [diff] [review]
Proposed patch

Looks good.

Comment 15

[[e-mail]]

Attachment: Fix view source of detached attachment

Comment 16

[David :Bienvenu]

Comment on attachment 214475 [details] [diff] [review]
Fix view source of detached attachment

nice

Comment 17

[[e-mail]]

Fix checked in to the trunk.

Comment 18

[Ian Neal]

Comment on attachment 214475 [details] [diff] [review]
Fix view source of detached attachment

a=me for SM1.1a

Comment 19

[[e-mail]]

Fixed checked in to the branch.