Enhance support for feed enclosures

RESOLVED FIXED in Thunderbird 16.0

Status

MailNews Core
Feed Reader
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: alta88, Assigned: alta88)

Tracking

unspecified
Thunderbird 16.0
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

10.64 KB, patch
alta88
: review+
Details | Diff | Splinter Review
(Assignee)

Description

5 years ago
this patch attempts:
1) support for more than 1 enclosure per message (not sure why such a simple thing wasn't implemented day one)
2) adds Atom support
3) adds <media:content> support
(Assignee)

Comment 1

5 years ago
Created attachment 631088 [details] [diff] [review]
patch
Assignee: nobody → alta88
Attachment #631088 - Flags: review?(dbienvenu)

Comment 2

5 years ago
alta88, any hints for how to test this patch?

Comment 3

5 years ago
Comment on attachment 631088 [details] [diff] [review]
patch

remove commented out line:

+//      tags = this.childrenByTagNameNS(itemNode, FeedUtils.MRSS_NS, "content");

It's up to you, but

for each (let tag in tags)

seems cleaner than

+        for (let j = 0; j < tags.length; j++)
+        {
+          let tag = tags[j];
Attachment #631088 - Flags: review?(dbienvenu) → review+
(Assignee)

Comment 4

5 years ago
(In reply to David :Bienvenu from comment #2)
> alta88, any hints for how to test this patch?

i've been using feeds like:
http://feeds.guardian.co.uk/theguardian/sport/rss
http://rss.cnn.com/rss/si_topstories.rss
(Assignee)

Comment 5

5 years ago
Created attachment 638206 [details] [diff] [review]
patch

address comments, patch for checkin.
Attachment #631088 - Attachment is obsolete: true
Attachment #638206 - Flags: review+
(Assignee)

Comment 6

5 years ago
(In reply to David :Bienvenu from comment #3)
> Comment on attachment 631088 [details] [diff] [review]
> 
> It's up to you, but
> 
> for each (let tag in tags)
> 
> seems cleaner than
> 
> +        for (let j = 0; j < tags.length; j++)
> +        {
> +          let tag = tags[j];

tags is either an array of nodes or a dom node collection object; since |for each| isn't for arrays, it's probably simpler to be old school and uniform in this case.
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/e62fe75b8abe
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 16.0
You need to log in before you can comment on or make changes to this bug.