Last Comment Bug 762631 - Enhance support for feed enclosures
: Enhance support for feed enclosures
Status: RESOLVED FIXED
:
Product: MailNews Core
Classification: Components
Component: Feed Reader (show other bugs)
: unspecified
: All All
: -- normal (vote)
: Thunderbird 16.0
Assigned To: alta88
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-06-07 12:39 PDT by alta88
Modified: 2012-07-02 15:13 PDT (History)
2 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch (10.72 KB, patch)
2012-06-07 12:44 PDT, alta88
mozilla: review+
Details | Diff | Review
patch (10.64 KB, patch)
2012-07-01 11:40 PDT, alta88
alta88: review+
Details | Diff | Review

Description alta88 2012-06-07 12:39:36 PDT
this patch attempts:
1) support for more than 1 enclosure per message (not sure why such a simple thing wasn't implemented day one)
2) adds Atom support
3) adds <media:content> support
Comment 1 alta88 2012-06-07 12:44:02 PDT
Created attachment 631088 [details] [diff] [review]
patch
Comment 2 David :Bienvenu 2012-06-14 16:50:23 PDT
alta88, any hints for how to test this patch?
Comment 3 David :Bienvenu 2012-06-15 07:27:00 PDT
Comment on attachment 631088 [details] [diff] [review]
patch

remove commented out line:

+//      tags = this.childrenByTagNameNS(itemNode, FeedUtils.MRSS_NS, "content");

It's up to you, but

for each (let tag in tags)

seems cleaner than

+        for (let j = 0; j < tags.length; j++)
+        {
+          let tag = tags[j];
Comment 4 alta88 2012-07-01 11:14:31 PDT
(In reply to David :Bienvenu from comment #2)
> alta88, any hints for how to test this patch?

i've been using feeds like:
http://feeds.guardian.co.uk/theguardian/sport/rss
http://rss.cnn.com/rss/si_topstories.rss
Comment 5 alta88 2012-07-01 11:40:04 PDT
Created attachment 638206 [details] [diff] [review]
patch

address comments, patch for checkin.
Comment 6 alta88 2012-07-01 11:43:55 PDT
(In reply to David :Bienvenu from comment #3)
> Comment on attachment 631088 [details] [diff] [review]
> 
> It's up to you, but
> 
> for each (let tag in tags)
> 
> seems cleaner than
> 
> +        for (let j = 0; j < tags.length; j++)
> +        {
> +          let tag = tags[j];

tags is either an array of nodes or a dom node collection object; since |for each| isn't for arrays, it's probably simpler to be old school and uniform in this case.
Comment 7 Ryan VanderMeulen [:RyanVM] 2012-07-02 15:13:20 PDT
https://hg.mozilla.org/comm-central/rev/e62fe75b8abe

Note You need to log in before you can comment on or make changes to this bug.