762631 - Enhance support for feed enclosures

Status: RESOLVED FIXED

(MailNews Core :: Feed Reader, defect)

Description

[alta88]

this patch attempts:
1) support for more than 1 enclosure per message (not sure why such a simple thing wasn't implemented day one)
2) adds Atom support
3) adds <media:content> support

Comment 1

[alta88]

Attachment: patch

Comment 2

[David :Bienvenu]

alta88, any hints for how to test this patch?

Comment 3

[David :Bienvenu]

Comment on attachment 631088 [details] [diff] [review]
patch

remove commented out line:

+//      tags = this.childrenByTagNameNS(itemNode, FeedUtils.MRSS_NS, "content");

It's up to you, but

for each (let tag in tags)

seems cleaner than

+        for (let j = 0; j < tags.length; j++)
+        {
+          let tag = tags[j];

Comment 4

[alta88]

(In reply to David :Bienvenu from comment #2)
> alta88, any hints for how to test this patch?

i've been using feeds like:
http://feeds.guardian.co.uk/theguardian/sport/rss
http://rss.cnn.com/rss/si_topstories.rss

Comment 5

[alta88]

Attachment: patch

address comments, patch for checkin.

Comment 6

[alta88]

(In reply to David :Bienvenu from comment #3)
> Comment on attachment 631088 [details] [diff] [review]
> 
> It's up to you, but
> 
> for each (let tag in tags)
> 
> seems cleaner than
> 
> +        for (let j = 0; j < tags.length; j++)
> +        {
> +          let tag = tags[j];

tags is either an array of nodes or a dom node collection object; since |for each| isn't for arrays, it's probably simpler to be old school and uniform in this case.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/e62fe75b8abe