Switch the 2d canvas context to new DOM bindings

RESOLVED FIXED in mozilla16

Status

()

Core
DOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: peterv, Assigned: peterv)

Tracking

Trunk
mozilla16
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
(Assignee)

Updated

5 years ago
Depends on: 762657
(Assignee)

Updated

5 years ago
Depends on: 761772
(Assignee)

Comment 1

5 years ago
Created attachment 631113 [details] [diff] [review]
v1
Comment on attachment 631113 [details] [diff] [review]
v1

Review of attachment 631113 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/Makefile.in
@@ +128,5 @@
>  
>  LOCAL_INCLUDES += \
>  		-I$(topsrcdir)/js/xpconnect/src \
>  		-I$(topsrcdir)/js/xpconnect/wrappers \
> +		-I$(topsrcdir)/content/canvas/src \

Why's that?
Blocks: 746773
FWIW we're getting pretty close to being able to remove nsCanvasRenderingContext2D, if that helps here.
(Assignee)

Comment 4

5 years ago
Created attachment 636489 [details] [diff] [review]
v1.1

This makes the pref for Azure canvas static, so requiring a restart after changing it.
I had to make nsIDOMCanvasRenderingContext2D_GetImageData a custom quickstub because ImageData is a non-wrappercached object with a new binding.
Attachment #631113 - Attachment is obsolete: true
Attachment #636489 - Flags: review?(bzbarsky)
Comment on attachment 636489 [details] [diff] [review]
v1.1

r=me
Attachment #636489 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 6

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/d6f341e77b68
Target Milestone: --- → mozilla16
Depends on: 769080
Sorry, I backed this out on inbound along with bug 762652 because Windows PGO builds were crashing in gfxContext::FillAzure:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9a2cc88619ba

https://tbpl.mozilla.org/php/getParsedLog.php?id=13051005&tree=Mozilla-Inbound
Target Milestone: mozilla16 → ---
(Assignee)

Comment 8

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/9feb8257666c
Target Milestone: --- → mozilla16
https://hg.mozilla.org/mozilla-central/rev/9feb8257666c
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Updated

5 years ago
Depends on: 776242
Depends on: 778128
No longer depends on: 778128
You need to log in before you can comment on or make changes to this bug.