When no symbol is found for a given offset, name it '0xNNNNNNNN' instead of '???'

RESOLVED FIXED

Status

()

Core
Gecko Profiler
--
minor
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: kael, Assigned: vladan)

Tracking

15 Branch
x86_64
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

5 years ago
Currently on Windows, SPS assigns all unknown offsets the name '???', making it impossible to tell them apart. The mac version represents them as hex addresses like '0xNNNNNNNN'. It'd be great if the Windows SPS code could do the same thing, so that you could at least try to manually identify individual unknown offsets by examining call hierarchies and time spent while you read a profile.
(Assignee)

Updated

5 years ago
Depends on: 763634
(Assignee)

Comment 1

5 years ago
https://github.com/vdjeric/Snappy-Symbolication-Server/commit/3df3d6b01850b288562f3dfc35fef9aa76db1175

Now just waiting on deployment to production environment
(Assignee)

Updated

5 years ago
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.