Use single AndroidHttpClient for all favicon requests

RESOLVED FIXED in Firefox 15

Status

()

Firefox for Android
General
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: bnicholson, Assigned: bnicholson)

Tracking

unspecified
Firefox 16
ARM
Android
Points:
---

Firefox Tracking Flags

(firefox15 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
As described in http://hc.apache.org/httpclient-3.x/performance.html#Reuse_of_HttpClient_instance, it's preferable to have a single HttpClient for all connections, as creating/closing the client is expensive.
(Assignee)

Comment 1

5 years ago
Created attachment 631170 [details] [diff] [review]
patch

This patch does a few things:
* Uses an AndroidHttpClient instead of an HttpClient. This automatically adds the client to a connection manager for us (so we don't have to worry about closing connections, being thread safe, etc)
* Uses our Fennec user agent
* Reuses the same HttpClient

Some sample times (ms) of how long it takes to fetch the Google favicon when doing some searches:

Before patch: 492, 568, 439, 553, 404, 394, 458
After patch: 255, 189, 80, 169, 61, 180, 94
Attachment #631170 - Flags: review?(mark.finkle)
Comment on attachment 631170 [details] [diff] [review]
patch

Nice
Attachment #631170 - Flags: review?(mark.finkle) → review+
(Assignee)

Comment 3

5 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/4663263e6dd7
https://hg.mozilla.org/mozilla-central/rev/4663263e6dd7

(Merged by Ed Morley)
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 16
(Assignee)

Comment 5

5 years ago
Comment on attachment 631170 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: Fennec UA isn't sent for favicon requests; favicons load slower
Testing completed (on m-c, etc.): 1 week on m-c
Risk to taking this patch (and alternatives if risky): low risk
String or UUID changes made by this patch: none
Attachment #631170 - Flags: approval-mozilla-aurora?

Updated

5 years ago
Attachment #631170 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(Assignee)

Comment 6

5 years ago
http://hg.mozilla.org/releases/mozilla-aurora/rev/2d25baeccf00
status-firefox15: --- → fixed
(Assignee)

Updated

5 years ago
Depends on: 774072
You need to log in before you can comment on or make changes to this bug.