762722 - Tabs UI buttons and rows should have orange highlight

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Sriram Ramasubramanian [:sriram]]

As a part of "orange" re-design, all the buttons and tappable portions are changing to orange. This now eats tabs UI too.

Comment 1

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch (1/2): Orange buttons

This adds orange highlight states to tab-buttons.

Comment 2

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch (2/2): Orange tabs

This patch (the-troublemaker!) changes the tabs to have orange highlight. :( :( :(

http://cl.ly/090s3d2J1j2g3V3r2L1d

( I really want to leave it in the current state.. pleaseeeee )

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 631482 [details] [diff] [review]
Patch (2/2): Orange tabs

Let UX see it in action

Comment 4

[Sriram Ramasubramanian [:sriram]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/1ec55f981c00
http://hg.mozilla.org/integration/mozilla-inbound/rev/5f82ac6575aa

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1ec55f981c00
https://hg.mozilla.org/mozilla-central/rev/5f82ac6575aa

Comment 6

[Catalin Suciu [:csuciu]]

Verified fixed on Nightly 16.0a1 (2012-06-12)
Samsung Galaxy SII (2.3.4)

Comment 7

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 631480 [details] [diff] [review]
Patch (1/2): Orange buttons

[Approval Request Comment]
Bug caused by (feature/regressing bug #): -
User impact if declined: Tabs UI wouldn't have orange highlights as per the new theme.
Testing completed (on m-c, etc.): 06/12
Risk to taking this patch (and alternatives if risky): Orange.. orange.. orange!
String or UUID changes made by this patch: -

Comment 8

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 631482 [details] [diff] [review]
Patch (2/2): Orange tabs

[Approval Request Comment]
Bug caused by (feature/regressing bug #): -
User impact if declined: Tabs UI wouldn't have orange highlights as per the new theme.
Testing completed (on m-c, etc.): 06/12
Risk to taking this patch (and alternatives if risky): Orange.. orange.. orange!
String or UUID changes made by this patch: -

Comment 9

[Alex Keybl [:akeybl]]

Comment on attachment 631480 [details] [diff] [review]
Patch (1/2): Orange buttons

[Triage Comment]
Tablet UI bugs are approved for Aurora 15, as they carry little risk to mobile and none to desktop.

Comment 10

[Alex Keybl [:akeybl]]

(In reply to Alex Keybl [:akeybl] from comment #9)

Errant mass modify. This remains approved, however. We'll back the tabs feature out if it poses significant issues before Beta.

Comment 11

[Sriram Ramasubramanian [:sriram]]

Pushed to aurora:
https://hg.mozilla.org/releases/mozilla-aurora/rev/72b01730bff8
https://hg.mozilla.org/releases/mozilla-aurora/rev/094da1a44995