762724 - Tabs button should merge with the Tabs UI when tabs are shown

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Sriram Ramasubramanian [:sriram]]

As a part of new design, the tabs button should merge with the tabs UI's dark background.

This requires newer resources on mdpi, hdpi and xhdpi scales.

Comment 1

[Sriram Ramasubramanian [:sriram]]

To avoid spamming:
This should also take care of the arrow to express the toggle behavior.
This requires newer resources.

My patch posted in bug 739407 has the required plumbing for this.
However, the arrows dont change orientation! (Android! I hate you!)

Comment 2

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch (1/2): Button change

This adds 2 more button states to tabs button, to make it feel complete in expanded view.

Comment 3

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch (2/2): Arrow directions

This patch adds (more) resources to change the direction of the arrow, based on open/close state of tabs UI.

Comment 5

[Sriram Ramasubramanian [:sriram]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/086c2e7be28a
http://hg.mozilla.org/integration/mozilla-inbound/rev/b993b4812103

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/086c2e7be28a
https://hg.mozilla.org/mozilla-central/rev/b993b4812103

Comment 7

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 632157 [details] [diff] [review]
Patch (1/2): Button change

[Approval Request Comment]
Bug caused by (feature/regressing bug #): -
User impact if declined: Fills the entire tab-button to merge with tabs UI
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky): None.
String or UUID changes made by this patch: -

Comment 8

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 632436 [details] [diff] [review]
Patch (2/2): Arrow directions

[Approval Request Comment]
Bug caused by (feature/regressing bug #): -
User impact if declined: Adds an arrow pointing the direction the tabs-ui will expand/collapse. This will be lost without this patch.
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky): None. 
String or UUID changes made by this patch:

Comment 9

[Alex Keybl [:akeybl]]

Comment on attachment 632157 [details] [diff] [review]
Patch (1/2): Button change

[Triage Comment]
Tablet UI bugs are approved for Aurora 15, as they carry little risk to mobile and none to desktop.

Comment 10

[Alex Keybl [:akeybl]]

(In reply to Alex Keybl [:akeybl] from comment #9)

Errant mass modify. This remains approved, however. We'll back the tabs feature out if it poses significant issues before Beta.

Comment 11

[Sriram Ramasubramanian [:sriram]]

Pushed to aurora:
https://hg.mozilla.org/releases/mozilla-aurora/rev/eed77f056867
https://hg.mozilla.org/releases/mozilla-aurora/rev/687dc23512ad

Comment 12

[Adrian Tamas (:AdrianT)]

The number of tabs and arrow is not displayed on the latest Nightly but this is covered in Bug 773181. The tabs button is merged when the tab menu is opened and the arrows are correct on Aurora. Marking as verified.

Verified on:
Nightly 16.0a1 2012-07-11/Aurora 15.0a2 2012-07-11
HTC Desire
Android 2.2.2