762725 - Sync button needs different states

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Sriram Ramasubramanian [:sriram]]

As a part of re-design, the "Synced tabs" has been modified to be a button. This is a toggle button. This needs the icon in different resolutions.

Comment 1

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch (1/2): Remote tab icons

This patch replaces the remote tab icons. Since the plumbing was already done, a XML change makes everything work fine.

Comment 2

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch (2/2): Tab "+" icons

I had cut down our army strength from 12 to 3 "tab_new" soldiers.
Meanwhile remote tabs had built its own battalion! And tab_new soldiers had put on weight and looked ugly in from of "remote tabs". Hence I recruited back the 9 other cousins of them, and took them to Ian's gym to make them look skinny! :D

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 631549 [details] [diff] [review]
Patch (2/2): Tab "+" icons

i hate needing to add all these damn images. damn you, android!

Comment 5

[Sriram Ramasubramanian [:sriram]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/5cb4218ef40a
http://hg.mozilla.org/integration/mozilla-inbound/rev/abab030e4e59

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/5cb4218ef40a
https://hg.mozilla.org/mozilla-central/rev/abab030e4e59

Comment 7

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 631548 [details] [diff] [review]
Patch (1/2): Remote tab icons

[Approval Request Comment]
Bug caused by (feature/regressing bug #):
User impact if declined: The dummy icons are replaced with proper icons in this patch. Without this the UI will be seem to be broken.
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky): -
String or UUID changes made by this patch:

Comment 8

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 631549 [details] [diff] [review]
Patch (2/2): Tab "+" icons

[Approval Request Comment]
Bug caused by (feature/regressing bug #): -
User impact if declined: Plus button will look awkward when it is near to a sync-tabs button.
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky): 
String or UUID changes made by this patch:

Comment 9

[Sriram Ramasubramanian [:sriram]]

Pushed to aurora:
https://hg.mozilla.org/releases/mozilla-aurora/rev/3c20bf3377f4
https://hg.mozilla.org/releases/mozilla-aurora/rev/086ffcb85684

Comment 10

[Adrian Tamas (:AdrianT)]

Synced tabs now have a computer icon which changes state if the synced tabs are hidden or displayed,

Verified on:
Nightly 16.0a1 2012-07-12/Aurora 15.0a2 2012-07-12
HTC Desire
Android 2.2.2