Export SSL key logging in normal builds

RESOLVED FIXED in 3.14

Status

NSS
Libraries
P2
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Wan-Teh Chang, Assigned: Adam Langley)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

5 years ago
Created attachment 631253 [details] [diff] [review]
Patch by Adam Langley

The attached patch, by Adam Langley, moves SSL key logging out from
behind the TRACE and DEBUG defines and allows normal builds to use
it when the SSLKEYLOGFILE environment variable is set. It also adds
a new CLIENT_RANDOM format to support ECDHE-RSA key agreement (and
others).

The patch was originally reviewed at
https://chromiumcodereview.appspot.com/10509009/.
Attachment #631253 - Flags: review+
(Reporter)

Comment 1

5 years ago
Patch checked in on the NSS trunk (NSS 3.14).

Checking in ssl3con.c;
/cvsroot/mozilla/security/nss/lib/ssl/ssl3con.c,v  <--  ssl3con.c
new revision: 1.182; previous revision: 1.181
done
Checking in sslsock.c;
/cvsroot/mozilla/security/nss/lib/ssl/sslsock.c,v  <--  sslsock.c
new revision: 1.90; previous revision: 1.89
done
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Priority: -- → P2
Resolution: --- → FIXED
(Reporter)

Comment 2

5 years ago
Created attachment 632081 [details] [diff] [review]
Update the SSL trace message and the comment in the SSL key log file

Patch by Adam Langley. Patch checked in on the NSS trunk (NSS 3.14).

Checking in sslsock.c;
/cvsroot/mozilla/security/nss/lib/ssl/sslsock.c,v  <--  sslsock.c
new revision: 1.92; previous revision: 1.91
done
You need to log in before you can comment on or make changes to this bug.