Missing MOZALLOC_EXPORT causes link failure on mingw

RESOLVED FIXED in mozilla16

Status

()

Core
mozglue
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Jacek Caban, Assigned: Jacek Caban)

Tracking

Trunk
mozilla16
x86
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 631366 [details] [diff] [review]
fix v1.0

It looks like bug 761859 accidentally removed MOZALLOC_EXPORT define, causing mozalloc_abort to not be marked as exported.

Successful try run:
https://tbpl.mozilla.org/?tree=Try&rev=e15ebf4408ca
Attachment #631366 - Flags: review?(ted.mielczarek)
Attachment #631366 - Attachment is patch: true
Comment on attachment 631366 [details] [diff] [review]
fix v1.0

Review of attachment 631366 [details] [diff] [review]:
-----------------------------------------------------------------

Oops, sorry.
Attachment #631366 - Flags: review?(ted.mielczarek) → review+
Blocks: 761859
(Assignee)

Comment 2

5 years ago
Thanks for the review.

https://hg.mozilla.org/integration/mozilla-inbound/rev/93214bac07b2
(Assignee)

Updated

5 years ago
Target Milestone: --- → mozilla16
(Assignee)

Comment 3

5 years ago
I accidentally referenced blocked bug instead of this one in the commit. Landed on m-c as:

https://hg.mozilla.org/mozilla-central/rev/93214bac07b2
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.