The following testcase crashes on ionmonkey revision 5cfb73435e06 (run with --ion -n -m --ion-eager): gcPreserveCode() options("allow_xml"); function TestCase(n, d, e, a) {} function reportCompare(expected, actual, description) { new TestCase } var actual = ''; var expect = ''; for (var i = 0; i < 2; ++i) reportCompare(expect, actual, ': 2'); gczeal(2); var summary = 'brian loves eval(s, o)'; isXMLName = 'locallocal'; eval("", {}); reportCompare(expect, actual, summary);
Crash info: ==11650== Jump to the invalid address stated on the next line ==11650== at 0xFFF: ??? ==11650== by 0x811B088: bool js::gc::Arena::finalize<JSObject>(js::FreeOp*, js::gc::AllocKind, unsigned int) (jsgc.cpp:303) ==11650== by 0x8116DD1: void js::gc::FinalizeTypedArenas<JSObject>(js::FreeOp*, js::gc::ArenaLists::ArenaList*, js::gc::AllocKind) (jsgc.cpp:350) ==11650== by 0x810B1CC: js::gc::FinalizeArenas(js::FreeOp*, js::gc::ArenaLists::ArenaList*, js::gc::AllocKind) (jsgc.cpp:390) ==11650== by 0x810DE34: js::gc::ArenaLists::finalizeNow(js::FreeOp*, js::gc::AllocKind) (jsgc.cpp:1495) ==11650== by 0x810DF6D: js::gc::ArenaLists::finalizeObjects(js::FreeOp*) (jsgc.cpp:1598) ==11650== by 0x8112A70: SweepPhase(JSRuntime*, js::JSGCInvocationKind, bool*) (jsgc.cpp:3333) ==11650== by 0x8114277: GCCycle(JSRuntime*, bool, long long, js::JSGCInvocationKind) (jsgc.cpp:3770) ==11650== by 0x81146C6: Collect(JSRuntime*, bool, long long, js::JSGCInvocationKind, js::gcreason::Reason) (jsgc.cpp:3866) ==11650== by 0x811485B: js::GC(JSRuntime*, js::JSGCInvocationKind, js::gcreason::Reason) (jsgc.cpp:3890) ==11650== by 0x80D0979: js::DestroyContext(JSContext*, js::DestroyContextMode) (jscntxt.cpp:319) ==11650== by 0x8087AB0: JS_DestroyContext (jsapi.cpp:1182) ==11650== Address 0xfff is not stack'd, malloc'd or (recently) free'd The address I saw varied, it wasn't fixed to 0xfff, therefore s-s.
In fact, I just got another test where it jumps to 0xdadadada. That sounds very easy to exploit :(
Created attachment 632086 [details] [diff] [review] fix After hours of debugging, I'm far too sober for this patch.
http://hg.mozilla.org/projects/ionmonkey/rev/3dc37e74fdf0
*** Bug 763440 has been marked as a duplicate of this bug. ***
*** Bug 762984 has been marked as a duplicate of this bug. ***
*** Bug 762907 has been marked as a duplicate of this bug. ***
*** Bug 762923 has been marked as a duplicate of this bug. ***
JSBugMon: This bug has been automatically verified fixed.
*** Bug 763112 has been marked as a duplicate of this bug. ***
*** Bug 763121 has been marked as a duplicate of this bug. ***
E4X has been removed, so we won't add the test.
or
