763001 - Typo in layout/style/nsCSSPseudoClassList.h

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

> 73 // -moz-lwtheme may be used to match a document that has a lightweight theme
> 74 CSS_PSEUDO_CLASS(mozLWTheme, ":-moz-lwtheme")
> 75 
> 76 // -moz-lwtheme-brighttext matches a document that has a bright lightweight theme
> 77 CSS_PSEUDO_CLASS(mozLWThemeBrightText, ":-moz-lwtheme-brighttext")
> 78 
> 79 // -moz-lwtheme-darktext matches a document that has a bright lightweight theme
> 80 CSS_PSEUDO_CLASS(mozLWThemeDarkText, ":-moz-lwtheme-darktext")

If the theme has brighttext then it is likely a dark lightweight theme, not a bright one :)

Comment 1

[raymond [:retornam] (inactive)]

Attachment: patch that fixes typo

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 631590 [details] [diff] [review]
patch that fixes typo

Review of attachment 631590 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/style/nsCSSPseudoClassList.h
@@ +80,1 @@
>  CSS_PSEUDO_CLASS(mozLWThemeDarkText, ":-moz-lwtheme-darktext")

It's actually the other way around. The darktext is used for bright themes and the brighttext is used for dark themes. Sorry if I was confusing in comment #0.

Comment 3

[Eric Wong (:ekw)]

Attachment: Patch

Hope it's OK I take this; it's been 6 months since last activity.

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 688124 [details] [diff] [review]
Patch

Review of attachment 688124 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, thanks for picking this up.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d59f0a346a9d

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/d59f0a346a9d