Closed Bug 763033 Opened 9 years ago Closed 9 years ago

Keep url bar blank on about:home

Categories

(Firefox :: General, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 16

People

(Reporter: limi, Assigned: jwilde)

Details

Attachments

(1 file, 1 obsolete file)

Currently, if you load about:home, it leaves "about:home" in the URL bar. It shouldn't do that.

It should work similarly to about:newtab, it's an implementation detail, and should never be surfaced in the UI.
Assignee: nobody → jonathan
Status: NEW → ASSIGNED
OS: Mac OS X → All
Hardware: x86 → All
Comment on attachment 631534 [details] [diff] [review]
Bug 763033 - about:home shouldn't show about:home in the location bar

Review of attachment 631534 [details] [diff] [review]:
-----------------------------------------------------------------

Oh, cool. I forgot about gInitialPages.
Nit: If you change the patch to add "about:home" between "about:newtab" and "about:privatebrowsing", we only need to change one line in the file, and the related pages are slightly better grouped. :)
Attachment #631534 - Flags: review+
Pushed to inbound!
https://hg.mozilla.org/integration/mozilla-inbound/rev/7377fb1cbdb8
Summary: about:home shouldn't show about:home in the location bar → Keep url bar blank on about:home
Target Milestone: --- → Firefox 16
Fixed.
Attachment #631534 - Attachment is obsolete: true
Flags: in-testsuite-
Attachment #631569 - Attachment description: Improved of elements in gInitialPages. → Improved order of elements in gInitialPages.
https://hg.mozilla.org/mozilla-central/rev/7377fb1cbdb8
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
(In reply to Frank Yan (:fryn) from comment #2)
> Oh, cool. I forgot about gInitialPages.
> Nit: If you change the patch to add "about:home" between "about:newtab" and
> "about:privatebrowsing"


fwiw, would have been nicer to keep the existing alphabetical order...
You need to log in before you can comment on or make changes to this bug.