763033 - Keep url bar blank on about:home

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Alex Limi (:limi) — Firefox UX Team]

Currently, if you load about:home, it leaves "about:home" in the URL bar. It shouldn't do that.

It should work similarly to about:newtab, it's an implementation detail, and should never be surfaced in the UI.

Comment 1

[Jonathan Wilde [:jwilde]]

Attachment: Bug 763033 - about:home shouldn't show about:home in the location bar

Comment 2

[Frank Yan (:fryn)]

Comment on attachment 631534 [details] [diff] [review]
Bug 763033 - about:home shouldn't show about:home in the location bar

Review of attachment 631534 [details] [diff] [review]:
-----------------------------------------------------------------

Oh, cool. I forgot about gInitialPages.
Nit: If you change the patch to add "about:home" between "about:newtab" and "about:privatebrowsing", we only need to change one line in the file, and the related pages are slightly better grouped. :)

Comment 3

[Frank Yan (:fryn)]

Pushed to inbound!
https://hg.mozilla.org/integration/mozilla-inbound/rev/7377fb1cbdb8

Comment 4

[Jonathan Wilde [:jwilde]]

Attachment: Improved order of elements in gInitialPages.

Fixed.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7377fb1cbdb8

Comment 6

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

(In reply to Frank Yan (:fryn) from comment #2)
> Oh, cool. I forgot about gInitialPages.
> Nit: If you change the patch to add "about:home" between "about:newtab" and
> "about:privatebrowsing"


fwiw, would have been nicer to keep the existing alphabetical order...