763103 - Encrypt key fields

Status: RESOLVED FIXED

(Marketplace Graveyard :: Payments/Refunds, defect, P1)

Description

[Andy McKay]

Should we be encrypting key fields?

Things include: pre-approval key, paypal_id of the seller.

If so how?

Comment 1

[Kumar McMillan [:kumar]]

rforbes: last time I remember talking about this we discussed using a key file on disk and doing AES encrypt/decrypt with the MySQL function. This is what we do for the in-app payment secrets: bug 742751

Comment 2

[Raymond Forbes[:rforbes]]

sounds good to me.

Comment 3

[Andy McKay]

I'd like to encrypt the following fields:

Buyers: key (< preapproval key)
Sellers: paypal_id (< paypal_email), token (< permissions token), secret (< permissions secret)

Is it possible to abstract that AES field a little so we just say models.AESField? Would be a nice library to have lying around for this stuff.

Comment 4

[Kumar McMillan [:kumar]]

(In reply to Andy McKay [:andym] from comment #3)
> Is it possible to abstract that AES field a little so we just say
> models.AESField? Would be a nice library to have lying around for this stuff.

Yeah, that's exactly what I'm thinking too. I think we can expand the implementation here https://github.com/mozilla/zamboni/commit/32883fe58a89b3f429a0512fd1f9ea50c4e33c66#L0R370 to be more like http://djangosnippets.org/snippets/2489/

Comment 5

[Andy McKay]

That would be awesome.

Comment 6

[Andy McKay]

@rforbes: does this encryption remove the requirement for bug 759021 or should that requirement be part of this bug?

Comment 7

[Andy McKay]

For the record, encryption of data using a PIN is not required. That will be seperate.

Comment 8

[Andy McKay]

https://github.com/mozilla/solitude/commit/aa971a