76311 - Bidi selection code fired on non-Bidi pages

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Simon Montagu :smontagu]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; WinNT4.0; en-US; m18) Gecko/20001231
BuildID:    

The IBMBIDI code in nsSelection::HandleDrag doesn't check that Bidi is enabled 
in the presentation context. This must be fixed to prevent performance hit on 
non-Bidi pages.

Reproducible: Always
Steps to Reproduce:
Open mozilla in a debugger.
Set a breakpoint in nsSelection::VisualSelectFrames in 
mozilla/content/base/src/nsSelection.cpp
Open any document with no Bidi content
Click and drag the mouse

Actual Results:  The breakpoint is reached

Expected Results:  This method should never be entered from a non-Bidi document

Comment 1

[Simon Montagu :smontagu]

Attachment: patch to nsSelection.cpp

Comment 2

[Simon Montagu :smontagu]

Assigning to Erik

Comment 3

[Doron Rosenberg (IBM)]

we need a bidi component...

Comment 4

[mjudge]

just looked at it with erik. looks good to me. r= mjudge

Comment 5

[Erik van der Poel]

sr=erik

Comment 6

[Erik van der Poel]

Fix checked in.

Comment 7

[Erik van der Poel]

Simon, thanks for coming up with a fix so quickly!

Comment 8

[Frank Tang]

I can no longer see the bug on my Mac bidi build after get erik's patch.