Closed Bug 763148 Opened 8 years ago Closed 8 years ago

put Relation into a11y namespace

Categories

(Core :: Disability Access APIs, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla16

People

(Reporter: surkov, Assigned: capella)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

file: accessible/src/base/Relation.h, see bug 763146 for the reference
Assignee: nobody → markcapella
Status: NEW → ASSIGNED
Attached patch Patch (v1)Splinter Review
This was interesting ....
Attachment #631718 - Flags: review?(surkov.alexander)
Comment on attachment 631718 [details] [diff] [review]
Patch (v1)

Review of attachment 631718 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/src/generic/RootAccessible.h
@@ +18,4 @@
>  namespace mozilla {
>  namespace a11y {
>  
> +class Relation;

you don't really need it since it's defined in Accessible.h, right?

::: accessible/src/msaa/ia2AccessibleRelation.h
@@ +14,5 @@
>  
>  #include "AccessibleRelation.h"
>  
> +namespace mozilla {
> +namespace a11y {

thanks
Attachment #631718 - Flags: review?(surkov.alexander) → review+
Yes, I was able to pull "relation.h". In the second example I assume you suggest I could also pull "accessiblerelatiio.h", but the build failed without it.
https://hg.mozilla.org/mozilla-central/rev/a08a067f2713
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.