The default bug view has changed. See this FAQ.

put Relation into a11y namespace

RESOLVED FIXED in mozilla16

Status

()

Core
Disability Access APIs
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: surkov, Assigned: capella)

Tracking

(Blocks: 1 bug)

unspecified
mozilla16
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
file: accessible/src/base/Relation.h, see bug 763146 for the reference
(Assignee)

Updated

5 years ago
Assignee: nobody → markcapella
Status: NEW → ASSIGNED
(Assignee)

Comment 1

5 years ago
Created attachment 631718 [details] [diff] [review]
Patch (v1)

This was interesting ....
Attachment #631718 - Flags: review?(surkov.alexander)
(Reporter)

Comment 2

5 years ago
Comment on attachment 631718 [details] [diff] [review]
Patch (v1)

Review of attachment 631718 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/src/generic/RootAccessible.h
@@ +18,4 @@
>  namespace mozilla {
>  namespace a11y {
>  
> +class Relation;

you don't really need it since it's defined in Accessible.h, right?

::: accessible/src/msaa/ia2AccessibleRelation.h
@@ +14,5 @@
>  
>  #include "AccessibleRelation.h"
>  
> +namespace mozilla {
> +namespace a11y {

thanks
Attachment #631718 - Flags: review?(surkov.alexander) → review+
(Assignee)

Comment 3

5 years ago
Yes, I was able to pull "relation.h". In the second example I assume you suggest I could also pull "accessiblerelatiio.h", but the build failed without it.
(Assignee)

Comment 4

5 years ago
TRY push
https://tbpl.mozilla.org/?tree=Try&rev=049e05386514
(Assignee)

Comment 5

5 years ago
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=a08a067f2713
Target Milestone: --- → mozilla16
https://hg.mozilla.org/mozilla-central/rev/a08a067f2713
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.