763148 - put Relation into a11y namespace

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[alexander :surkov (:asurkov)]

file: accessible/src/base/Relation.h, see bug 763146 for the reference

Comment 1

[Mark Capella [:capella]]

Attachment: Patch (v1)

This was interesting ....

Comment 2

[alexander :surkov (:asurkov)]

Comment on attachment 631718 [details] [diff] [review]
Patch (v1)

Review of attachment 631718 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/src/generic/RootAccessible.h
@@ +18,4 @@
>  namespace mozilla {
>  namespace a11y {
>  
> +class Relation;

you don't really need it since it's defined in Accessible.h, right?

::: accessible/src/msaa/ia2AccessibleRelation.h
@@ +14,5 @@
>  
>  #include "AccessibleRelation.h"
>  
> +namespace mozilla {
> +namespace a11y {

thanks

Comment 3

[Mark Capella [:capella]]

Yes, I was able to pull "relation.h". In the second example I assume you suggest I could also pull "accessiblerelatiio.h", but the build failed without it.

Comment 4

[Mark Capella [:capella]]

TRY push
https://tbpl.mozilla.org/?tree=Try&rev=049e05386514

Comment 5

[Mark Capella [:capella]]

https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=a08a067f2713

Comment 6

[Graeme McCutcheon [:graememcc]]

https://hg.mozilla.org/mozilla-central/rev/a08a067f2713