Closed Bug 763150 Opened 8 years ago Closed 8 years ago
remove notification methods from ns
1) remove these ContentRangeInserted, ContentRemoved, NotifyOfAnchorJumpTo, PresShellDestroyed from nsIAccessibilityService (accessible/public) 2) remove virtual keyword for these methods defined on nsAccessibiltiyService (accessible/src/base) 3) move method comments into nsAccessibilitySerivce Oussama wanna take?
ok, I will check....
Thank you to assign me to this bug!!
Comment on attachment 632735 [details] [diff] [review] Patch V1 to fix Bug 763150. >+ /** >+ * Adds/remove ATK root accessible for gtk+ native window to/from children >+ * of the application accessible. >+ */ > virtual nsAccessible* AddNativeRootAccessible(void* not sure why you make this change, but I don't see it hurting anything.
Attachment #632735 - Flags: review?(surkov.alexander) → review+
Coz I see that the comment was missed there, and IMHO, I think it's useful to add comments for more details, but not excessively !!!
Alexander, can you CC me in a new bug? thks!
rebased and tested locally ... over to TRY it goes: https://tbpl.mozilla.org/?tree=Try&rev=3ee9554fd2e8
Looks good there, lets go to inbound: https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=8cd2ae931ba8
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
You need to log in before you can comment on or make changes to this bug.