remove notification methods from nsIAccessibilityService

RESOLVED FIXED in mozilla16

Status

()

Core
Disability Access APIs
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: surkov, Unassigned)

Tracking

(Blocks: 1 bug)

unspecified
mozilla16
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
1) remove these
ContentRangeInserted, ContentRemoved, NotifyOfAnchorJumpTo, PresShellDestroyed from nsIAccessibilityService (accessible/public)
2) remove virtual keyword for these methods defined on nsAccessibiltiyService (accessible/src/base)
3) move method comments into nsAccessibilitySerivce

Oussama wanna take?

Comment 1

5 years ago
ok, I will check....

Comment 2

5 years ago
Thank you to assign me to this bug!!

Comment 3

5 years ago
Created attachment 632735 [details] [diff] [review]
Patch V1 to fix Bug 763150.
Attachment #632735 - Flags: review?(surkov.alexander)
Comment on attachment 632735 [details] [diff] [review]
Patch V1 to fix Bug 763150.

>+  /**
>+   * Adds/remove ATK root accessible for gtk+ native window to/from children
>+   * of the application accessible.
>+   */
>   virtual nsAccessible* AddNativeRootAccessible(void* 

not sure why you make this change, but I don't see it hurting anything.
Attachment #632735 - Flags: review?(surkov.alexander) → review+

Comment 5

5 years ago
Coz I see that the comment was missed there, and IMHO, I think it's useful to add comments for more details, but not excessively !!!

Comment 6

5 years ago
Alexander, can you CC me in a new bug?
thks!
rebased and tested locally ... over to TRY it goes:
https://tbpl.mozilla.org/?tree=Try&rev=3ee9554fd2e8
Looks good there, lets go to inbound:
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=8cd2ae931ba8
https://hg.mozilla.org/mozilla-central/rev/8cd2ae931ba8
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
You need to log in before you can comment on or make changes to this bug.