763150 - remove notification methods from nsIAccessibilityService

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[alexander :surkov (:asurkov)]

1) remove these
ContentRangeInserted, ContentRemoved, NotifyOfAnchorJumpTo, PresShellDestroyed from nsIAccessibilityService (accessible/public)
2) remove virtual keyword for these methods defined on nsAccessibiltiyService (accessible/src/base)
3) move method comments into nsAccessibilitySerivce

Oussama wanna take?

Comment 1

[Oussama BADR]

ok, I will check....

Comment 2

[Oussama BADR]

Thank you to assign me to this bug!!

Comment 3

[Oussama BADR]

Attachment: Patch V1 to fix Bug 763150.

Comment 4

[Trevor Saunders (:tbsaunde)]

Comment on attachment 632735 [details] [diff] [review]
Patch V1 to fix Bug 763150.

>+  /**
>+   * Adds/remove ATK root accessible for gtk+ native window to/from children
>+   * of the application accessible.
>+   */
>   virtual nsAccessible* AddNativeRootAccessible(void* 

not sure why you make this change, but I don't see it hurting anything.

Comment 5

[Oussama BADR]

Coz I see that the comment was missed there, and IMHO, I think it's useful to add comments for more details, but not excessively !!!

Comment 6

[Oussama BADR]

Alexander, can you CC me in a new bug?
thks!

Comment 7

[Mark Capella [:capella]]

rebased and tested locally ... over to TRY it goes:
https://tbpl.mozilla.org/?tree=Try&rev=3ee9554fd2e8

Comment 8

[Mark Capella [:capella]]

Looks good there, lets go to inbound:
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=8cd2ae931ba8

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8cd2ae931ba8