Last Comment Bug 763150 - remove notification methods from nsIAccessibilityService
: remove notification methods from nsIAccessibilityService
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Disability Access APIs (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla16
Assigned To: Nobody; OK to take it and work on it
:
Mentors:
Depends on:
Blocks: 738221
  Show dependency treegraph
 
Reported: 2012-06-08 23:08 PDT by alexander :surkov
Modified: 2012-06-24 20:08 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch V1 to fix Bug 763150. (4.79 KB, patch)
2012-06-13 09:23 PDT, Oussama BADR
tbsaunde+mozbugs: review+
Details | Diff | Splinter Review

Description alexander :surkov 2012-06-08 23:08:10 PDT
1) remove these
ContentRangeInserted, ContentRemoved, NotifyOfAnchorJumpTo, PresShellDestroyed from nsIAccessibilityService (accessible/public)
2) remove virtual keyword for these methods defined on nsAccessibiltiyService (accessible/src/base)
3) move method comments into nsAccessibilitySerivce

Oussama wanna take?
Comment 1 Oussama BADR 2012-06-09 07:53:01 PDT
ok, I will check....
Comment 2 Oussama BADR 2012-06-13 08:31:26 PDT
Thank you to assign me to this bug!!
Comment 3 Oussama BADR 2012-06-13 09:23:55 PDT
Created attachment 632735 [details] [diff] [review]
Patch V1 to fix Bug 763150.
Comment 4 Trevor Saunders (:tbsaunde) 2012-06-13 12:40:01 PDT
Comment on attachment 632735 [details] [diff] [review]
Patch V1 to fix Bug 763150.

>+  /**
>+   * Adds/remove ATK root accessible for gtk+ native window to/from children
>+   * of the application accessible.
>+   */
>   virtual nsAccessible* AddNativeRootAccessible(void* 

not sure why you make this change, but I don't see it hurting anything.
Comment 5 Oussama BADR 2012-06-13 13:52:01 PDT
Coz I see that the comment was missed there, and IMHO, I think it's useful to add comments for more details, but not excessively !!!
Comment 6 Oussama BADR 2012-06-23 04:54:11 PDT
Alexander, can you CC me in a new bug?
thks!
Comment 7 Mark Capella [:capella] 2012-06-23 16:51:44 PDT
rebased and tested locally ... over to TRY it goes:
https://tbpl.mozilla.org/?tree=Try&rev=3ee9554fd2e8
Comment 8 Mark Capella [:capella] 2012-06-23 23:31:11 PDT
Looks good there, lets go to inbound:
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=8cd2ae931ba8
Comment 9 Ryan VanderMeulen [:RyanVM] 2012-06-24 20:08:42 PDT
https://hg.mozilla.org/mozilla-central/rev/8cd2ae931ba8

Note You need to log in before you can comment on or make changes to this bug.