Closed
Bug 763150
Opened 12 years ago
Closed 12 years ago
remove notification methods from nsIAccessibilityService
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla16
People
(Reporter: surkov, Unassigned)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
4.79 KB,
patch
|
tbsaunde
:
review+
|
Details | Diff | Splinter Review |
1) remove these ContentRangeInserted, ContentRemoved, NotifyOfAnchorJumpTo, PresShellDestroyed from nsIAccessibilityService (accessible/public) 2) remove virtual keyword for these methods defined on nsAccessibiltiyService (accessible/src/base) 3) move method comments into nsAccessibilitySerivce Oussama wanna take?
Comment 1•12 years ago
|
||
ok, I will check....
Comment 2•12 years ago
|
||
Thank you to assign me to this bug!!
Comment 3•12 years ago
|
||
Attachment #632735 -
Flags: review?(surkov.alexander)
Comment 4•12 years ago
|
||
Comment on attachment 632735 [details] [diff] [review] Patch V1 to fix Bug 763150. >+ /** >+ * Adds/remove ATK root accessible for gtk+ native window to/from children >+ * of the application accessible. >+ */ > virtual nsAccessible* AddNativeRootAccessible(void* not sure why you make this change, but I don't see it hurting anything.
Attachment #632735 -
Flags: review?(surkov.alexander) → review+
Comment 5•12 years ago
|
||
Coz I see that the comment was missed there, and IMHO, I think it's useful to add comments for more details, but not excessively !!!
Comment 6•12 years ago
|
||
Alexander, can you CC me in a new bug? thks!
Comment 7•12 years ago
|
||
rebased and tested locally ... over to TRY it goes: https://tbpl.mozilla.org/?tree=Try&rev=3ee9554fd2e8
Comment 8•12 years ago
|
||
Looks good there, lets go to inbound: https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=8cd2ae931ba8
Comment 9•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/8cd2ae931ba8
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
You need to log in
before you can comment on or make changes to this bug.
Description
•