Closed Bug 763152 Opened 12 years ago Closed 12 years ago

Building against libxul-sdk doesn't link against jemalloc

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Platform:
All
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox15 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla16
Tracking Flags:
Tracking Status
firefox15 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file)

Link against libmemory when building against a libxul-sdk that ships it
1.35 KB, patch
khuey
: review+
lsblakk
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
In bug 736564, jemalloc was moved out of mozglue and shipped separately in the sdk. When building against the sdk, we only link against mozglue instead of both mozglue and jemalloc.
status-firefox15: --- → affected
Assignee: nobody → mh+mozilla
Attachment #631620 - Flags: review?(ted.mielczarek) → review?(khuey)
https://hg.mozilla.org/mozilla-central/rev/4a4519b018e9
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment on attachment 631620 [details] [diff] [review]
Link against libmemory when building against a libxul-sdk that ships it

[Approval Request Comment]
Bug caused by bug 736564
User impact if declined: Firefox built as a Xulrunner application crashes during startup.
Risk to taking this patch (and alternatives if risky): The patch is NPOTB for anything built at Mozilla.
String or UUID changes made by this patch: None.
Attachment #631620 - Flags: approval-mozilla-aurora?
Comment on attachment 631620 [details] [diff] [review]
Link against libmemory when building against a libxul-sdk that ships it

[Triage Comment]
NPOTB, no problems.
Attachment #631620 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: