Last Comment Bug 763204 - Context menu should not handle OGG audio as OGV video.
: Context menu should not handle OGG audio as OGV video.
Status: RESOLVED FIXED
:
Product: SeaMonkey
Classification: Client Software
Component: General (show other bugs)
: Trunk
: All All
: -- normal (vote)
: seamonkey2.13
Assigned To: Philip Chee
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-06-09 09:27 PDT by Philip Chee
Modified: 2012-06-16 10:49 PDT (History)
0 users
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Patch v1.0 Fixit. (70.07 KB, patch)
2012-06-09 09:42 PDT, Philip Chee
no flags Details | Diff | Review
Patch v1.1 rearrange Makefile.in (70.11 KB, patch)
2012-06-16 03:17 PDT, Philip Chee
neil: review+
Details | Diff | Review

Description Philip Chee 2012-06-09 09:27:05 PDT
From Bug 557278:

> When I open an audio stream (e.g http://ct1.party107.com:8000/Party107-Q0.ogg)
> and then right-click on the player, I get options like:
> 'view video', 'copy video location', etc. Those should be 'play audio', 'copy
> audio location', 'save audio', 'send audio', etc.
Comment 1 Philip Chee 2012-06-09 09:42:15 PDT
Created attachment 631671 [details] [diff] [review]
Patch v1.0 Fixit.

$ MOZ_NO_REMOTE=1 TEST_PATH=suite/browser/test/test_contextmenu.html  pymake -C ../objdir-sm/ mochitest-plain

Passed: 1713
Failed: 0
Todo: 0

Note this test is disabled on Linux due to random ORANGEs.
Comment 2 neil@parkwaycc.co.uk 2012-06-09 14:56:19 PDT
Comment on attachment 631671 [details] [diff] [review]
Patch v1.0 Fixit.

>-		test_contextmenu.html \
>-		subtst_contextmenu.html \
> 		ctxmenu-image.png \
> 		video.ogg \
Aren't these test files too?

>+# test_contextmenu.html is disabled on Linux due to bug 513558
This is disabled because a) we're already hitting this randomorange b) Firefox has already disabled it c) other?

>+		audio.ogg \
>+		test_contextmenu.html \
>+		subtst_contextmenu.html \
Any particular order to these files?
Comment 3 Philip Chee 2012-06-16 03:17:31 PDT
Created attachment 633788 [details] [diff] [review]
Patch v1.1 rearrange Makefile.in

>>-		test_contextmenu.html \
>>-		subtst_contextmenu.html \
>> 		ctxmenu-image.png \
>> 		video.ogg \
> Aren't these test files too?
Hmm. Yes. Firefox uses them for other tests. Since we haven't ported those yet, I'll move them as well.

>>+# test_contextmenu.html is disabled on Linux due to bug 513558
> This is disabled because a) we're already hitting this randomorange b) Firefox has already disabled it c) other?
(b) Plus Serge filed Bug 513558 so I'll save him some work by disabling it on Linux for us as well.

>>+		audio.ogg \
>>+		test_contextmenu.html \
>>+		subtst_contextmenu.html \
> Any particular order to these files?
I think based on the original order in Firefox the main test file should go first followed by the resources used so it should be something like:

	test_contextmenu.html \
	subtst_contextmenu.html \
	ctxmenu-image.png \
	video.ogg \
	audio.ogg \
Comment 4 neil@parkwaycc.co.uk 2012-06-16 07:31:03 PDT
Comment on attachment 633788 [details] [diff] [review]
Patch v1.1 rearrange Makefile.in

a) would have been the ideal reason, but b) will do ;-)
Comment 5 Philip Chee 2012-06-16 10:49:31 PDT
Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/bca02d8d10bd

Note You need to log in before you can comment on or make changes to this bug.