763214 - [shipping] remove the etag from signoff view altogether

Status: RESOLVED FIXED

(Webtools Graveyard :: Elmo, defect, P3)

Description

[Axel Hecht [:Pike]]

Regression from bug 650816, the etag needs to follow pushes through the trees, and not just take the latest.

Comment 1

[Axel Hecht [:Pike]]

We may just want to fix bug 729599 instead, though.

Comment 2

[Axel Hecht [:Pike]]

I'll do a hotfix and disable the etag for now to make sure that we're updating the pages right.

Comment 3

[[github robot]]

Commit pushed to develop at https://github.com/mozilla/elmo

https://github.com/mozilla/elmo/commit/431205a2786d8ce4cf428e39ad2320e3584c8352
bug 763214, disable etag caching while we're waiting for a fix

Comment 4

[Axel Hecht [:Pike]]

This hotfix breaks tests, but that's fine for a bustage fix.

Comment 5

[[github robot]]

Commit pushed to develop at https://github.com/mozilla/elmo

https://github.com/mozilla/elmo/commit/2300597b7867a3d6ce26a7fafa2ed40c35c14f61
bug 763214, more paper: add XXX comment and disable test, rs=me

Comment 6

[Axel Hecht [:Pike]]

So, here's the scoop:

When we get a new migration, trees_over_time changes. It should probably be good enough to include the latest AppVersionTreeThrough in the etag, and then check for builds/pushes in the time frame for the current tree. that is, restrict those more, but add a new key entry that invalidates the key on migration day.

Comment 7

[Peter Bengtsson [:peterbe]]

So, not by actions?!

Either way, in the meantime I'm trying to build something to the tune of that scoop on the AppVersionTreeThrough.

Comment 8

[Peter Bengtsson [:peterbe]]

How about this?
http://www.hastebin.com/biyekamana.py

So, instead of using the current tree (and its Runs and Pushes) we use the latest migration date. 
Have I understood this correctly? 
I tried with /shipping/signoffs/he/calendar1.6 and is seems to work since on the same date as `last_migration` you did the migration with the message "Migrating aurora to beta for 14"

One thing I still don't really understand is: "then check for builds/pushes in the time frame for the current tree". Surely you mean of the latest tree migration?
Or do you genuinely mean that I should look for any Pushes and Runs more recent than that date?

Lastly, why does this need to be so complicated?! :)

Comment 9

[[github robot]]

Commit pushed to develop at https://github.com/mozilla/elmo

https://github.com/mozilla/elmo/commit/4d58ac7f6bbd6d3d07fef134181a73630020313f
bug 763214 - drop commented out etag for signoff view, rs=Pike

Comment 10

[[github robot]]

Commit pushed to develop at https://github.com/mozilla/elmo

https://github.com/mozilla/elmo/commit/e9a6969afefc159148f8338f2e92ec9dffc9e534
bug 763214 - removed signoff etag test which was disabled, rs=Pike