763223 - "ASSERTION: parentSize should be valid" with huge padding

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Jesse Ruderman]

Attachment: testcase

###!!! ASSERTION: parentSize should be valid: 'parentSize.width != NS_INTRINSICSIZE && parentSize.height != NS_INTRINSICSIZE', file layout/base/nsCSSFrameConstructor.cpp, line 11994

This assertion was added in bug 157681.

Comment 1

[Jesse Ruderman]

Attachment: stack trace

Comment 2

[(no longer active)]

So the right padding here is a large value, which causes tons of these types of warnings: "have unconstrained width; this should only result from very large sizes, not attempts at intrinsic width calculation: 'aContainingBlockWidth != NS_UNCONSTRAINEDSIZE'", and also causes the width value to be unconstrained size, which triggers this assertion.

How are we supposed to handle cases like this with huge values in layout?

Comment 3

[Boris Zbarsky [:bzbarsky]]

We don't really have a plan for these.  :(

Comment 4

[(no longer active)]

So there isn't too much we can do about this assertion, except for taking it out?

Comment 5

[Jesse Ruderman]

I have an idea in bug 765861.  For now, this should probably be downgraded to a warning.

Comment 6

[(no longer active)]

Attachment: Patch (v1)

This patch converts the assertion into a warning.

Comment 7

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Comment on attachment 634258 [details] [diff] [review]
Patch (v1)

Please use NS_WARN_IF_FALSE instead of the #ifdef and NS_WARNING.  r=dbaron with that

Comment 8

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a7f575fe03e0

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a7f575fe03e0