Last Comment Bug 763223 - "ASSERTION: parentSize should be valid" with huge padding
: "ASSERTION: parentSize should be valid" with huge padding
Status: RESOLVED FIXED
: assertion, regression, testcase
Product: Core
Classification: Components
Component: Layout (show other bugs)
: Trunk
: x86_64 Mac OS X
: -- normal (vote)
: mozilla16
Assigned To: :Ehsan Akhgari
:
Mentors:
Depends on:
Blocks: randomstyles 157681
  Show dependency treegraph
 
Reported: 2012-06-09 12:44 PDT by Jesse Ruderman
Modified: 2012-07-10 15:49 PDT (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
testcase (286 bytes, text/html)
2012-06-09 12:44 PDT, Jesse Ruderman
no flags Details
stack trace (1.31 KB, text/plain)
2012-06-09 12:44 PDT, Jesse Ruderman
no flags Details
Patch (v1) (2.13 KB, patch)
2012-06-18 17:58 PDT, :Ehsan Akhgari
dbaron: review+
Details | Diff | Splinter Review

Description Jesse Ruderman 2012-06-09 12:44:10 PDT
Created attachment 631688 [details]
testcase

###!!! ASSERTION: parentSize should be valid: 'parentSize.width != NS_INTRINSICSIZE && parentSize.height != NS_INTRINSICSIZE', file layout/base/nsCSSFrameConstructor.cpp, line 11994

This assertion was added in bug 157681.
Comment 1 Jesse Ruderman 2012-06-09 12:44:33 PDT
Created attachment 631689 [details]
stack trace
Comment 2 :Ehsan Akhgari 2012-06-18 10:39:39 PDT
So the right padding here is a large value, which causes tons of these types of warnings: "have unconstrained width; this should only result from very large sizes, not attempts at intrinsic width calculation: 'aContainingBlockWidth != NS_UNCONSTRAINEDSIZE'", and also causes the width value to be unconstrained size, which triggers this assertion.

How are we supposed to handle cases like this with huge values in layout?
Comment 3 Boris Zbarsky [:bz] (still a bit busy) 2012-06-18 10:51:22 PDT
We don't really have a plan for these.  :(
Comment 4 :Ehsan Akhgari 2012-06-18 10:53:34 PDT
So there isn't too much we can do about this assertion, except for taking it out?
Comment 5 Jesse Ruderman 2012-06-18 12:05:53 PDT
I have an idea in bug 765861.  For now, this should probably be downgraded to a warning.
Comment 6 :Ehsan Akhgari 2012-06-18 17:58:58 PDT
Created attachment 634258 [details] [diff] [review]
Patch (v1)

This patch converts the assertion into a warning.
Comment 7 David Baron :dbaron: ⌚️UTC-7 (busy September 14-25) 2012-07-09 15:11:32 PDT
Comment on attachment 634258 [details] [diff] [review]
Patch (v1)

Please use NS_WARN_IF_FALSE instead of the #ifdef and NS_WARNING.  r=dbaron with that
Comment 9 Ryan VanderMeulen [:RyanVM] 2012-07-10 15:49:09 PDT
https://hg.mozilla.org/mozilla-central/rev/a7f575fe03e0

Note You need to log in before you can comment on or make changes to this bug.