The default bug view has changed. See this FAQ.

Fix freetype detection on Non X11 linux builds

RESOLVED FIXED in mozilla16

Status

()

Core
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: romaxa, Assigned: romaxa)

Tracking

unspecified
mozilla16
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Created attachment 631711 [details] [diff] [review]
Check freetype under USE_FC_FREETYPE ifdef

On attempt to build on Linux without X11 (cairo-qt for example)
I see message like:
ERROR: Can't find header fontconfig/fcfreetype.h.

I think we should move freetype detection part out of X11 test
Attachment #631711 - Flags: review?(mh+mozilla)
Comment on attachment 631711 [details] [diff] [review]
Check freetype under USE_FC_FREETYPE ifdef

Review of attachment 631711 [details] [diff] [review]:
-----------------------------------------------------------------

::: configure.in
@@ +8858,5 @@
>  
>  if test "$USE_FC_FREETYPE"; then
> +    dnl ========================================================
> +    dnl = Check for freetype2 and its functionality
> +    dnl ========================================================

This needs to be under the COMPILE_ENVIRONMENT test.
Attachment #631711 - Flags: review?(mh+mozilla) → review+
(Assignee)

Comment 2

5 years ago
Created attachment 631997 [details] [diff] [review]
Check freetype under USE_FC_FREETYPE ifdef

Got build error on try for original patch, due to undefinde CAIRO_FT_FLAGS..

So I moved whole check little bit above that test.
try build for that looks good
https://tbpl.mozilla.org/?tree=Try&rev=ca07bf26a527
Assignee: nobody → romaxa
Attachment #631711 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #631997 - Flags: review?(mh+mozilla)
Attachment #631997 - Flags: review?(mh+mozilla) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/0890dcf220c7
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/0890dcf220c7
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
You need to log in before you can comment on or make changes to this bug.