Last Comment Bug 763247 - "ASSERTION: rescheduling interval timeout without a timer" with setInterval, sync XHR, mozRequestAnimationFrame
: "ASSERTION: rescheduling interval timeout without a timer" with setInterval, ...
Status: RESOLVED FIXED
: assertion, testcase
Product: Core
Classification: Components
Component: DOM (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla16
Assigned To: Nathan Froyd [:froydnj]
:
: Andrew Overholt [:overholt]
Mentors:
Depends on: 748464
Blocks: 326633
  Show dependency treegraph
 
Reported: 2012-06-09 20:22 PDT by Jesse Ruderman
Modified: 2012-06-14 02:46 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
testcase (203 bytes, text/html)
2012-06-09 20:22 PDT, Jesse Ruderman
no flags Details
stack trace (4.10 KB, text/plain)
2012-06-09 20:22 PDT, Jesse Ruderman
no flags Details
patch (977 bytes, patch)
2012-06-13 12:29 PDT, Nathan Froyd [:froydnj]
bzbarsky: review+
Details | Diff | Splinter Review

Description Jesse Ruderman 2012-06-09 20:22:16 PDT
Created attachment 631715 [details]
testcase

###!!! ASSERTION: rescheduling interval timeout without a timer!: 'timeout->mTimer', file dom/base/nsGlobalWindow.cpp, line 9337

This assertion was added in bug 748464.
Comment 1 Jesse Ruderman 2012-06-09 20:22:34 PDT
Created attachment 631716 [details]
stack trace
Comment 2 Boris Zbarsky [:bz] (still a bit busy) 2012-06-11 09:31:33 PDT
Nathan, can you take a look, please?  Note the sync XHR spinning the event loop in there...
Comment 3 Nathan Froyd [:froydnj] 2012-06-13 12:27:37 PDT
Ah, yes, in RescheduleTimeout, we say:

+  if (!aTimeout->mTimer) {
+    NS_ASSERTION(IsFrozen() || mTimeoutsSuspendDepth,
+                 "How'd our timer end up null if we're not frozen or "
+                 "suspended?");
+
+    aTimeout->mTimeRemaining = delay;
+    return true;
+  }

which will wind up hitting that added assertion.  I'll prepare a patch to remove it.
Comment 4 Nathan Froyd [:froydnj] 2012-06-13 12:29:29 PDT
Created attachment 632813 [details] [diff] [review]
patch

Should be easy enough to review!
Comment 5 Boris Zbarsky [:bz] (still a bit busy) 2012-06-13 13:24:47 PDT
Comment on attachment 632813 [details] [diff] [review]
patch

r=me
Comment 7 Ed Morley [:emorley] 2012-06-14 02:46:25 PDT
https://hg.mozilla.org/mozilla-central/rev/eaab1f7507f7

Note You need to log in before you can comment on or make changes to this bug.