763247 - "ASSERTION: rescheduling interval timeout without a timer" with setInterval, sync XHR, mozRequestAnimationFrame

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Jesse Ruderman]

Attachment: testcase

###!!! ASSERTION: rescheduling interval timeout without a timer!: 'timeout->mTimer', file dom/base/nsGlobalWindow.cpp, line 9337

This assertion was added in bug 748464.

Comment 1

[Jesse Ruderman]

Attachment: stack trace

Comment 2

[Boris Zbarsky [:bzbarsky]]

Nathan, can you take a look, please?  Note the sync XHR spinning the event loop in there...

Comment 3

[Nathan Froyd [:froydnj]]

Ah, yes, in RescheduleTimeout, we say:

+  if (!aTimeout->mTimer) {
+    NS_ASSERTION(IsFrozen() || mTimeoutsSuspendDepth,
+                 "How'd our timer end up null if we're not frozen or "
+                 "suspended?");
+
+    aTimeout->mTimeRemaining = delay;
+    return true;
+  }

which will wind up hitting that added assertion.  I'll prepare a patch to remove it.

Comment 4

[Nathan Froyd [:froydnj]]

Attachment: patch

Should be easy enough to review!

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 632813 [details] [diff] [review]
patch

r=me

Comment 6

[Nathan Froyd [:froydnj]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/eaab1f7507f7

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/eaab1f7507f7