763305 - Add a reflectDouble() method in reflect.js

Status: RESOLVED INACTIVE

(Core :: DOM: Core & HTML, defect, P5)

Description

[Mounir Lamouri (:mounir)]

Would be needed for stuff like inptu.valueAsNumber.

Comment 1

[sindhusridhar]

Hi Mounir,

Have you assigned this bug to anyone ?

Comment 2

[Mounir Lamouri (:mounir)]

No, this bug is free to be taken ;)

Comment 3

[sindhusridhar]

awesome .I would like to work on this bug.But since I am a beginner to the mozilla developer community ,I might need some 
help on getting started and where to start for this particular bug.

Comment 4

[sindhusridhar]

awesome .I would like to work on this bug.But since I am a beginner to the mozilla developer community ,I might need some 
help on getting started and where to start for this particular bug.

Comment 5

[Mounir Lamouri (:mounir)]

The file is:
content/html/content/test/reflect.js

You will find other methods that are used to test reflection from other types.

See the specification explaining how reflection works:
http://www.whatwg.org/specs/web-apps/current-work/multipage/common-dom-interfaces.html#reflect

Comment 6

[Abhishek Potnis [:avp]]

Hello,

Can I work on this bug ? Or has this bug been assigned to someone ?


Thanks.

Comment 7

[Mounir Lamouri (:mounir)]

(In reply to Abhishek Potnis [:abhishekp] from comment #6)
> Hello,
> 
> Can I work on this bug ? Or has this bug been assigned to someone ?
> 
> 
> Thanks.

This bug is definitely assignee-free. Do not hesitate to ping me or Ms2ger to get some help.
Also, have a look at this wiki page to begin with Mozilla hacking: https://developer.mozilla.org/en/Introduction

Comment 8

[Michał Frontczak [:fxa90id] ♥]

can I pick this ? It seems nobody works on it

Comment 9

[Sunny [:darkowlzz]]

Attachment: Added reflectDouble() method

Hi,
I would like to work on this bug. 
I have attached whatever I have tried. Please check it and suggest what more is required.

Thanks.

Comment 10

[Mounir Lamouri (:mounir)]

Comment on attachment 710749 [details] [diff] [review]
Added reflectDouble() method

Review of attachment 710749 [details] [diff] [review]:
-----------------------------------------------------------------

This is doing basic testing but we would like deeper testing ideally like handling edge cases and some odd values - look at what other tests do.
You can try to do something not too complex for a first patch and improve it later but I think you could easily add more cases in the first patch.

Also, you should definitely try to find an attribute on which you could test this on. input.valueAsNumber isn't a great idea (contrary to what I said in comment 0). However, progress.max would work well I believe.

::: content/html/content/test/reflect.js
@@ +238,5 @@
>    }
>  }
>  
>  /**
> + * Checks that a given attribute name for a given element is correctly reflected as a double 

nit: there is a trailing whitespace here. Replace it with a dot.

Comment 11

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1472046

Move all DOM bugs that haven’t been updated in more than 3 years and has no one currently assigned to P5.

If you have questions, please contact :mdaly.