Closed Bug 763348 Opened 8 years ago Closed 7 years ago

assertion errors in worker tests

Categories

(Core :: JavaScript Engine, defect, critical)

x86_64
Linux
defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla16

People

(Reporter: Benjamin, Assigned: Benjamin)

Details

Attachments

(1 file)

$ ./configure --enable-debug --disable-optimize --enable-threadsafe --with-system-nspr
$ tests/jstests.py _DBG.OBJ/js worker -o
    rc = 0, run time = 0.034421
 PASSED! worker-error

jstest: undefined bug:  result: PASSED type: shell description: worker-error reason: 

    rc = 0, run time = 0.052837
 PASSED! worker-init

jstest: undefined bug:  result: PASSED type: shell description: worker-init reason: 

    rc = -11, run time = 0.049652
Assertion failure: JSVAL_IS_DOUBLE(v), at ../../jsapi.h:1927
REGRESSION - js1_8_5/extensions/worker-terminate.js
    rc = -11, run time = 0.064559
Assertion failure: JSVAL_IS_DOUBLE(v), at ../../jsapi.h:1927
REGRESSION - js1_8_5/extensions/worker-fib.js
    rc = 0, run time = 0.063370
 PASSED! worker-simple

jstest: undefined bug:  result: PASSED type: shell description: worker-simple reason: 

    rc = 0, run time = 0.059212
 PASSED! typeof event.message

jstest: undefined bug:  result: PASSED type: shell description: typeof event.message reason: 

    rc = 6, run time = 1.040414
--- NOTE: IN THIS TESTCASE, WE EXPECT EXIT CODE 6 ---
Script runs for too long, terminating.
REGRESSIONS
    js1_8_5/extensions/worker-terminate.js
    js1_8_5/extensions/worker-fib.js
FAIL
Attached patch fixSplinter Review
Looks like a simple oversight. (Are the tests for this thing never run?)
Attachment #632083 - Flags: review?(jorendorff)
Evidently bustage from bug 697537.
Attachment #632083 - Flags: review?(jorendorff) → review+
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/1eb234066998
Assignee: general → bpeterson
Flags: in-testsuite+
Keywords: checkin-needed
Target Milestone: --- → mozilla16
https://hg.mozilla.org/mozilla-central/rev/1eb234066998
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.