Closed Bug 763388 Opened 10 years ago Closed 10 years ago

Remove enablePrivilege calls from IndexedDB and FileHandle tests

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla16

People

(Reporter: janv, Assigned: janv)

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Attached patch fix (obsolete) — Splinter Review
Assignee: nobody → Jan.Varga
Status: NEW → ASSIGNED
Attachment #631837 - Flags: review?(bent.mozilla)
Comment on attachment 631837 [details] [diff] [review]
fix

ted should review the special powers API changes.
Attachment #631837 - Flags: review?(ted.mielczarek)
Comment on attachment 631837 [details] [diff] [review]
fix

Review of attachment 631837 [details] [diff] [review]:
-----------------------------------------------------------------

I'm not wild about the SpecialPowers changes (seems like you could just expose the thread manager to accomplish some of this stuff), but I'll let ted be the final judge.

::: dom/file/test/test_lockedfile_lifetimes_nested.html
@@ +23,5 @@
>  
>        let lockedFile = fileHandle.open();
>  
>        let lockedFile2;
> +      SpecialPowers.executeSoonSync(function() {

SimpleTest has an executeSoon you can use. Then you won't have to make a new one in SpecialPowers.
Attachment #631837 - Flags: review?(bent.mozilla) → review+
(In reply to ben turner [:bent] from comment #4)
> ::: dom/file/test/test_lockedfile_lifetimes_nested.html
> @@ +23,5 @@
> >  
> >        let lockedFile = fileHandle.open();
> >  
> >        let lockedFile2;
> > +      SpecialPowers.executeSoonSync(function() {
> 
> SimpleTest has an executeSoon you can use. Then you won't have to make a new
> one in SpecialPowers.

Ben, this one is special, see the "Sync".
It waits for the event to be processed.

I'm willing to rework it if we decide to just expose the thread manager.
(In reply to Jan Varga [:janv] from comment #5)
> I'm willing to rework it if we decide to just expose the thread manager.

or even the Indexed Database Manager
Attached patch alternative fixSplinter Review
this adds only one tiny method to SpecialPowers
Attachment #633916 - Flags: review?(bent.mozilla)
Attachment #633916 - Flags: review?(bent.mozilla) → review+
Attachment #631837 - Attachment is obsolete: true
Attachment #631837 - Flags: review?(ted.mielczarek)
https://hg.mozilla.org/mozilla-central/rev/d3211f786f5f
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.