Remove enablePrivilege calls from IndexedDB and FileHandle tests

RESOLVED FIXED in mozilla16

Status

()

Core
DOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: janv, Assigned: janv)

Tracking

unspecified
mozilla16
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

12.50 KB, patch
Ben Turner (not reading bugmail, use the needinfo flag!)
: review+
Details | Diff | Splinter Review
Comment hidden (empty)
(Assignee)

Comment 1

5 years ago
Created attachment 631837 [details] [diff] [review]
fix
Assignee: nobody → Jan.Varga
Status: NEW → ASSIGNED
Attachment #631837 - Flags: review?(bent.mozilla)
Comment on attachment 631837 [details] [diff] [review]
fix

ted should review the special powers API changes.
Attachment #631837 - Flags: review?(ted.mielczarek)
(Assignee)

Comment 3

5 years ago
try looks good:
https://tbpl.mozilla.org/?tree=Try&rev=04f82dc63a45
Comment on attachment 631837 [details] [diff] [review]
fix

Review of attachment 631837 [details] [diff] [review]:
-----------------------------------------------------------------

I'm not wild about the SpecialPowers changes (seems like you could just expose the thread manager to accomplish some of this stuff), but I'll let ted be the final judge.

::: dom/file/test/test_lockedfile_lifetimes_nested.html
@@ +23,5 @@
>  
>        let lockedFile = fileHandle.open();
>  
>        let lockedFile2;
> +      SpecialPowers.executeSoonSync(function() {

SimpleTest has an executeSoon you can use. Then you won't have to make a new one in SpecialPowers.
Attachment #631837 - Flags: review?(bent.mozilla) → review+
(Assignee)

Comment 5

5 years ago
(In reply to ben turner [:bent] from comment #4)
> ::: dom/file/test/test_lockedfile_lifetimes_nested.html
> @@ +23,5 @@
> >  
> >        let lockedFile = fileHandle.open();
> >  
> >        let lockedFile2;
> > +      SpecialPowers.executeSoonSync(function() {
> 
> SimpleTest has an executeSoon you can use. Then you won't have to make a new
> one in SpecialPowers.

Ben, this one is special, see the "Sync".
It waits for the event to be processed.

I'm willing to rework it if we decide to just expose the thread manager.
(Assignee)

Comment 6

5 years ago
(In reply to Jan Varga [:janv] from comment #5)
> I'm willing to rework it if we decide to just expose the thread manager.

or even the Indexed Database Manager
(Assignee)

Comment 7

5 years ago
Created attachment 633916 [details] [diff] [review]
alternative fix

this adds only one tiny method to SpecialPowers
Attachment #633916 - Flags: review?(bent.mozilla)
Attachment #633916 - Flags: review?(bent.mozilla) → review+
(Assignee)

Updated

5 years ago
Attachment #631837 - Attachment is obsolete: true
Attachment #631837 - Flags: review?(ted.mielczarek)
(Assignee)

Comment 8

5 years ago
https://hg.mozilla.org/mozilla-central/rev/d3211f786f5f
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Assignee)

Updated

5 years ago
Target Milestone: --- → mozilla16
You need to log in before you can comment on or make changes to this bug.