Last Comment Bug 763388 - Remove enablePrivilege calls from IndexedDB and FileHandle tests
: Remove enablePrivilege calls from IndexedDB and FileHandle tests
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla16
Assigned To: Jan Varga [:janv]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-06-11 00:15 PDT by Jan Varga [:janv]
Modified: 2012-06-18 10:28 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
fix (14.60 KB, patch)
2012-06-11 02:51 PDT, Jan Varga [:janv]
bent.mozilla: review+
Details | Diff | Review
alternative fix (12.50 KB, patch)
2012-06-17 11:49 PDT, Jan Varga [:janv]
bent.mozilla: review+
Details | Diff | Review

Description Jan Varga [:janv] 2012-06-11 00:15:21 PDT

    
Comment 1 Jan Varga [:janv] 2012-06-11 02:51:24 PDT
Created attachment 631837 [details] [diff] [review]
fix
Comment 2 Bobby Holley (busy) 2012-06-11 02:53:20 PDT
Comment on attachment 631837 [details] [diff] [review]
fix

ted should review the special powers API changes.
Comment 3 Jan Varga [:janv] 2012-06-11 03:02:22 PDT
try looks good:
https://tbpl.mozilla.org/?tree=Try&rev=04f82dc63a45
Comment 4 Ben Turner (not reading bugmail, use the needinfo flag!) 2012-06-11 15:54:12 PDT
Comment on attachment 631837 [details] [diff] [review]
fix

Review of attachment 631837 [details] [diff] [review]:
-----------------------------------------------------------------

I'm not wild about the SpecialPowers changes (seems like you could just expose the thread manager to accomplish some of this stuff), but I'll let ted be the final judge.

::: dom/file/test/test_lockedfile_lifetimes_nested.html
@@ +23,5 @@
>  
>        let lockedFile = fileHandle.open();
>  
>        let lockedFile2;
> +      SpecialPowers.executeSoonSync(function() {

SimpleTest has an executeSoon you can use. Then you won't have to make a new one in SpecialPowers.
Comment 5 Jan Varga [:janv] 2012-06-11 20:44:23 PDT
(In reply to ben turner [:bent] from comment #4)
> ::: dom/file/test/test_lockedfile_lifetimes_nested.html
> @@ +23,5 @@
> >  
> >        let lockedFile = fileHandle.open();
> >  
> >        let lockedFile2;
> > +      SpecialPowers.executeSoonSync(function() {
> 
> SimpleTest has an executeSoon you can use. Then you won't have to make a new
> one in SpecialPowers.

Ben, this one is special, see the "Sync".
It waits for the event to be processed.

I'm willing to rework it if we decide to just expose the thread manager.
Comment 6 Jan Varga [:janv] 2012-06-11 20:46:31 PDT
(In reply to Jan Varga [:janv] from comment #5)
> I'm willing to rework it if we decide to just expose the thread manager.

or even the Indexed Database Manager
Comment 7 Jan Varga [:janv] 2012-06-17 11:49:25 PDT
Created attachment 633916 [details] [diff] [review]
alternative fix

this adds only one tiny method to SpecialPowers
Comment 8 Jan Varga [:janv] 2012-06-18 10:27:48 PDT
https://hg.mozilla.org/mozilla-central/rev/d3211f786f5f

Note You need to log in before you can comment on or make changes to this bug.