Closed
Bug 763396
Opened 12 years ago
Closed 12 years ago
VKB is not dismissed when switching tabs
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox18 verified)
VERIFIED
FIXED
Firefox 16
Tracking | Status | |
---|---|---|
firefox18 | --- | verified |
People
(Reporter: paul.feher, Assigned: bnicholson)
References
Details
Attachments
(1 file)
1.85 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
Nightly Fennec 16.0a1 (2012-06-10) Device: HTC Desire Z OS: Android 2.3.3 Steps to Reproduce: 1. Open two or more pages in different tabs. 2. Open a new tab and load a page that contains a text input field and tap on it for the VKB to appear (ex: google.com) 3. Open the tab menu and switch to another tab. Expected: The VKB is dismissed. Actual: The VKB is not dismissed.
Reporter | ||
Updated•12 years ago
|
blocking-fennec1.0: --- → ?
Updated•12 years ago
|
Assignee: nobody → bnicholson
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #631995 -
Flags: review?(mark.finkle)
Comment 2•12 years ago
|
||
> Step #3: "Open the tab menu and switch to another tab."
Shouldn't we have the fix in Tabs.selectTab(...) ?
Assignee | ||
Comment 3•12 years ago
|
||
(In reply to Mark Finkle (:mfinkle) from comment #2) > > Step #3: "Open the tab menu and switch to another tab." > > Shouldn't we have the fix in Tabs.selectTab(...) ? That means the keyboard would still be visible when we click the tabs tray button and until the user actually selects a tab, which can potentially hide some of the tabs in the tabs tray. This patch should put us back the previous behavior before the regression from bug 739407, but we can also put this in selectTab() for tabs that are changed programmatically.
Comment 4•12 years ago
|
||
IMO the VKB should be dismissed as soon as the tabs menu is invoked, for the reasons you already mentioned, Brian.
Comment 6•12 years ago
|
||
I can reproduce in Galaxy S2 using Android 2.3.4 and Nightly 20120618. I think it's worth to fix because the VKB should be dismissed as soon as the tabs menu is invoked, as stated above
tracking-fennec: --- → ?
Comment 7•12 years ago
|
||
Comment on attachment 631995 [details] [diff] [review] patch > private void toggleTabs() { > if (GeckoApp.mAppContext.areTabsShown()) > GeckoApp.mAppContext.hideTabs(); >- else >+ else { >+ InputMethodManager imm = >+ (InputMethodManager) mContext.getSystemService(Context.INPUT_METHOD_SERVICE); >+ imm.hideSoftInputFromWindow(mTabs.getWindowToken(), 0); > GeckoApp.mAppContext.showLocalTabs(); >+ } the "if" block needs {} now too: if () { } else { } Also, we need a bug for closing the keyboard in selectTab
Attachment #631995 -
Flags: review?(mark.finkle) → review+
Assignee | ||
Comment 8•12 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/e031f55fd997
Assignee | ||
Comment 9•12 years ago
|
||
(In reply to Mark Finkle (:mfinkle) from comment #7) > Also, we need a bug for closing the keyboard in selectTab Filed bug 767147.
Comment 10•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e031f55fd997
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 16
Comment 11•12 years ago
|
||
This issue is not longer reproducible on the latest Nightly build. Closing bug as verified fixed on: Firefox 18.0a1 (2012-09-12) Device: Galaxy Note OS: Android 4.0.4
Status: RESOLVED → VERIFIED
status-firefox18:
--- → verified
Updated•11 years ago
|
tracking-fennec: ? → ---
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•