763411 - Elements cut-off in preferences dialog for rm locale

Status: RESOLVED FIXED

(Mozilla Localizations :: rm / Romansh, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Our Mozmill l10n tests have been shown that there are some elements which are cut-off due to the localization. The results of the test you can find here:

http://mozmill-ci.blargon7.com/#/l10n/report/ee284dfa9d664754a65676abbc00d413

Details:

 Node is cut off by 15 px at the bottom: listitem#en. Parent node: listboxbody[rows=6][xbl:inherits=rows,size,minheight]
Node is cut off by 12 px at the bottom: tabbox#advancedPrefs. Parent node: vbox[xbl:inherits=flex][class=content-box]
Node is cut off by 12 px at the bottom: tabbox#advancedPrefs. Parent node: vbox[xbl:inherits=flex][class=content-box]
Node is cut off by 12 px at the bottom: tabbox#advancedPrefs. Parent node: vbox[xbl:inherits=flex][class=content-box]
Node is cut off by 12 px at the bottom: tabbox#advancedPrefs. Parent node: vbox[xbl:inherits=flex][class=content-box]

Comment 1

[Gion-Andri Cantieni [:gion-andri]]

(In reply to Henrik Skupin (:whimboo) from comment #0)
> Node is cut off by 15 px at the bottom: listitem#en. Parent node:
> listboxbody[rows=6][xbl:inherits=rows,size,minheight]

This is a false positive caused by bug 763461 (list in language-choose-window). 

> Node is cut off by 12 px at the bottom: tabbox#advancedPrefs. Parent node:
> vbox[xbl:inherits=flex][class=content-box]
> Node is cut off by 12 px at the bottom: tabbox#advancedPrefs. Parent node:
> vbox[xbl:inherits=flex][class=content-box]
> Node is cut off by 12 px at the bottom: tabbox#advancedPrefs. Parent node:
> vbox[xbl:inherits=flex][class=content-box]
> Node is cut off by 12 px at the bottom: tabbox#advancedPrefs. Parent node:
> vbox[xbl:inherits=flex][class=content-box]

These errors appear because the string 'offlineNotify.label' is too long. Maybe we could shorten it to "Confermar, sche websites vulan memorisar datas per l'utilisaziun offline." I'll discuss this in the team. 

Thanks Henrik for your help.

Comment 2

[Gion-Andri Cantieni [:gion-andri]]

Fixed in 
http://hg.mozilla.org/releases/l10n/mozilla-aurora/rm/rev/9f43a411b359

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

It's better but not enough. The rounded border at the bottom is still not present. I will attach a screenshot.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: screenshot

Comment 5

[Gion-Andri Cantieni [:gion-andri]]

Attachment: Screenshot with rounded border

On my machine, with changed string, the rounded border is there. But there isn't an Aurora-build with the commit yet. 
How did you do this screenshot?

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

No, there is no rounded border in your screenshot. What I mean is the groupbox, which is the small border right above the question mark.

The Aurora build I have used is:
http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-mozilla-aurora-l10n/firefox-16.0a2.ro.mac.dmg

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Sorry my fault. The Aurora build I was using haven't had this change included. Latest tinderbox build works fine.

Comment 8

[Gion-Andri Cantieni [:gion-andri]]

I also pushed this change to beta: 
http://hg.mozilla.org/releases/l10n/mozilla-beta/rm/rev/aeaf8151847b